[jira] [Commented] (AMBARI-16094) Improvements to DB consistency check

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-16094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270521#comment-15270521 ] 

Hadoop QA commented on AMBARI-16094:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12802150/AMBARI-16094.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.controller.internal.HostResourceProviderTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6775//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6775//console

This message is automatically generated.

> Improvements to DB consistency check
> ------------------------------------
>
>                 Key: AMBARI-16094
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16094
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Vitaly Brodetskyi
>            Assignee: Vitaly Brodetskyi
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-16094.patch
>
>
> * disable (we can remove later) DatabaseCheck
> * Have CheckDatabaseHelper be called as part of ambari-server start
> ** Modify {{ambari-server start}} to so that it calls {{ambari-server check-database}}
> *ambari-server check-database improvements*
> * On the output modify {{Ambari Server 'check-database' completed successfully.}} to {{Ambari Server 'check-database' completed.}} - _remove successfully_
> * Use “--skip-database-check” (not skip-database-validation) to force ambari-server to start despite error
> * If there is error when check-database is run then use the following text
> {code}
> DB configs consistency check failed. Run “ambari-server start --skip-database-check” to skip. If you use this “--skip-database-check” option, do not make any changes to your cluster topology or perform a cluster upgrade until you correct the database consistency issues. See "/var/log/ambari-server/ambari-check-database.log" for more details on the consistency issues.
> {code}
> *ambari-server start improvements*
> * On Ambari Server start, the output failure text to should mention ambari-server.log (in addition to .out file it does today)
> * If user has not specified {{--skip-database-check}} fail start command if check-database reports error
> * When user starts server with --skip-database-check, if there are DB check errors, print message:
> {code}
> Ambari Server is starting with the database consistency check skipped. Do not make any changes to your cluster topology or perform a cluster upgrade until you correct the database consistency issues. See "/var/log/ambari-server/ambari-check-database.log" for more details on the consistency issues.
> {code}
> When using log file paths, make sure to use the right path from log4j.
> *Optional*
> Modify ambari.properties to add {{database_check_error_skipped=true}} if user started with {{--skip-database-check}} and there were errors due to database-check. If there are no errors then store {{database_check_error_skipped=false}}. Eventually, UI will use this property and show warnings to the user and even prevent HDP upgrade or other topology modifying operations such as Add Host/Service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)