You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/02 17:16:30 UTC

[GitHub] [calcite] vlsi commented on issue #1717: [CALCITE-3667] EnumerableMergeJoin should not use take-while enumerat…

vlsi commented on issue #1717: [CALCITE-3667] EnumerableMergeJoin should not use take-while enumerat…
URL: https://github.com/apache/calcite/pull/1717#issuecomment-570275226
 
 
   Frankly speaking, I'm looking into reverting the change to `mergeJoin(...)` method:
   1) Reverting the method would keep backward compatibility with linq4j API
   2) The current implementation is not different from the old `mergeJoin(...).where(...)`, thus it would be better to just generate `.where(...)` code in `EnumerableMergeJoin` than alter `mergeJoin` API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services