You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/05/08 07:56:48 UTC
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
-----------------------------------------------------------
(Updated May 8, 2017, 3:56 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added authorization for frameworks in `GetRoles` v1 API.
Diffs (updated)
-----
src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
Diff: https://reviews.apache.org/r/58099/diff/5/
Changes: https://reviews.apache.org/r/58099/diff/4-5/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Jay Guo <gu...@gmail.com>.
> On May 17, 2017, 4:29 p.m., Adam B wrote:
> > Seems like we're adding even more duplicate code into this v1 clone of `roles()`. Can you find a way to reduce the redundance?
OK, let me take look and may submit some follow-up patches for it.
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review175219
-----------------------------------------------------------
On June 22, 2017, 2:02 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 2:02 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authorization for frameworks in `GetRoles` v1 API.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67
> src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9
>
>
> Diff: https://reviews.apache.org/r/58099/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review175219
-----------------------------------------------------------
Seems like we're adding even more duplicate code into this v1 clone of `roles()`. Can you find a way to reduce the redundance?
- Adam B
On May 10, 2017, 6:52 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 6:52 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authorization for frameworks in `GetRoles` v1 API.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
>
>
> Diff: https://reviews.apache.org/r/58099/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174594
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 10, 2017, 6:52 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 6:52 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authorization for frameworks in `GetRoles` v1 API.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
>
>
> Diff: https://reviews.apache.org/r/58099/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
-----------------------------------------------------------
(Updated June 22, 2017, 2:02 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
rebase and address comments
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added authorization for frameworks in `GetRoles` v1 API.
Diffs (updated)
-----
src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67
src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9
Diff: https://reviews.apache.org/r/58099/diff/7/
Changes: https://reviews.apache.org/r/58099/diff/6-7/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174543
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On May 10, 2017, 3:52 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 3:52 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authorization for frameworks in `GetRoles` v1 API.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
>
>
> Diff: https://reviews.apache.org/r/58099/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
-----------------------------------------------------------
(Updated May 10, 2017, 9:52 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Changes
-------
address comments.
Bugs: MESOS-7260
https://issues.apache.org/jira/browse/MESOS-7260
Repository: mesos
Description
-------
Added authorization for frameworks in `GetRoles` v1 API.
Diffs (updated)
-----
src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
Diff: https://reviews.apache.org/r/58099/diff/6/
Changes: https://reviews.apache.org/r/58099/diff/5-6/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174166
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 8, 2017, 7:56 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 7:56 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authorization for frameworks in `GetRoles` v1 API.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
>
>
> Diff: https://reviews.apache.org/r/58099/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 58099: Added authorization for frameworks in
`GetRoles` v1 API.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174461
-----------------------------------------------------------
src/master/http.cpp
Line 3647 (original), 3670-3676 (patched)
<https://reviews.apache.org/r/58099/#comment247633>
As in previous patch, I feel it is better if you do:
```c++
if (approveViewFrameworkInfo(frameworkApprover, framework->info)) {
role.add_frameworks()->CopyFrom(frameworkId);
}
```
- Alexander Rojas
On May 8, 2017, 9:56 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 9:56 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
>
>
> Bugs: MESOS-7260
> https://issues.apache.org/jira/browse/MESOS-7260
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added authorization for frameworks in `GetRoles` v1 API.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
>
>
> Diff: https://reviews.apache.org/r/58099/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>