You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "ffang (via GitHub)" <gi...@apache.org> on 2025/11/27 17:54:02 UTC
[PR] [CXF-9177] make MetricsProvider to accommodate customized MetricsProv… [cxf]
ffang opened a new pull request, #2756:
URL: https://github.com/apache/cxf/pull/2756
…ider implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9177] make MetricsProvider to accommodate customized MetricsProv… [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang merged PR #2756:
URL: https://github.com/apache/cxf/pull/2756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9177] make MetricsProvider to accommodate customized MetricsProv… [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2756:
URL: https://github.com/apache/cxf/pull/2756#discussion_r2569967823
##########
systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/MicrometerMetricsHttpProvider.java:
##########
@@ -40,16 +40,24 @@
import io.micrometer.core.instrument.Gauge;
import io.micrometer.core.instrument.LongTaskTimer;
import io.micrometer.core.instrument.Meter;
+import io.micrometer.core.instrument.MeterRegistry;
import io.micrometer.core.instrument.TimeGauge;
import io.micrometer.core.instrument.Timer;
+
@WebServiceProvider(serviceName = "MetricsService", portName = "MetricsPort", targetNamespace = "urn:metrics")
@ServiceMode(Service.Mode.MESSAGE)
@BindingType(jakarta.xml.ws.http.HTTPBinding.HTTP_BINDING)
public class MicrometerMetricsHttpProvider implements Provider<Source> {
@Resource
private WebServiceContext wsContext;
+
+ private MeterRegistry meterRegistry;
Review Comment:
```suggestion
private final MeterRegistry meterRegistry;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9177] make MetricsProvider to accommodate customized MetricsProv… [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on PR #2756:
URL: https://github.com/apache/cxf/pull/2756#issuecomment-3589615292
Thanks @reta !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org