[GitHub] spark pull request: [SPARK-9182][SQL] Cast filters are not passed ...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on the pull request:

    https://github.com/apache/spark/pull/8718#issuecomment-146380223
  
    @liancheng Would this casting check be unsafe?
    I came across Parquet downcasting check with the actual value 
    ```java
      public static int checkedCast(long value) {
        int valueI = (int) value;
        if (valueI != value) {
          throw new IllegalArgumentException(String.format("Overflow casting %d to an int", value));
        }
        return valueI;
      }
    ```
    
    and I see the use of `null` from `eval()` in other codes in Spark.
    
    I would like to close this PR, If this approach is inappropriate for other reasons.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org