You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/05/05 14:40:12 UTC
[GitHub] [fineract] John-Woodlock opened a new pull request, #2316: FINERACT-1557 enable previous disabled refundByCash accounting tests
John-Woodlock opened a new pull request, #2316:
URL: https://github.com/apache/fineract/pull/2316
postgresql query binding issue
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] John-Woodlock commented on pull request #2316: FINERACT-1557 enable previous disabled refundByCash accounting tests
Posted by GitBox <gi...@apache.org>.
John-Woodlock commented on PR #2316:
URL: https://github.com/apache/fineract/pull/2316#issuecomment-1119446919
can the failing mariadb build be rerun? works fine on local and on my github. No change to it. Fell over creating a loan product (nothing to do with test directly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2316: FINERACT-1557 enable previous disabled refundByCash accounting tests
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2316:
URL: https://github.com/apache/fineract/pull/2316#issuecomment-1119399768
@John-Woodlock could you please do a rebase to the latest develop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2316: FINERACT-1557 enable previous disabled refundByCash accounting tests
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2316:
URL: https://github.com/apache/fineract/pull/2316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org