You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/08/21 10:04:51 UTC
Review Request 37674: SQOOP-2518: Sqoop2: Findbugs: Fix warning in
repository-derby module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37674/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Fix warning in repository-derby module
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2408558
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 7678d35
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java eb8a905
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java 2322553
Diff: https://reviews.apache.org/r/37674/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 37674: SQOOP-2518: Sqoop2: Findbugs: Fix warning in
repository-derby module
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37674/#review96150
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 21, 2015, 8:04 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37674/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 8:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fix warning in repository-derby module
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2408558
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 7678d35
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java eb8a905
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java 2322553
>
> Diff: https://reviews.apache.org/r/37674/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 37674: SQOOP-2518: Sqoop2: Findbugs: Fix warning in
repository-derby module
Posted by Jarek Cecho <ja...@apache.org>.
> On Aug. 21, 2015, 9:08 p.m., Abraham Elmahrek wrote:
> > Java 7 or newer only. Requirements say Java 6 should be supported for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java.
I've synced up with Abe offline, we're missing updating documentation that Java 7 is required now that is covered in SQOOP-2520.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37674/#review96090
-----------------------------------------------------------
On Aug. 21, 2015, 8:04 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37674/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 8:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fix warning in repository-derby module
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2408558
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 7678d35
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java eb8a905
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java 2322553
>
> Diff: https://reviews.apache.org/r/37674/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 37674: SQOOP-2518: Sqoop2: Findbugs: Fix warning in
repository-derby module
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37674/#review96090
-----------------------------------------------------------
Java 7 or newer only. Requirements say Java 6 should be supported for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java.
- Abraham Elmahrek
On Aug. 21, 2015, 8:04 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37674/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 8:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fix warning in repository-derby module
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 2408558
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 7678d35
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java eb8a905
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java 2322553
>
> Diff: https://reviews.apache.org/r/37674/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>