You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/08/09 00:02:37 UTC

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7622

Change subject: IMPALA-5652: deprecate unlimited process mem_limit
......................................................................

IMPALA-5652: deprecate unlimited process mem_limit

Testing:
Started cluster locally with:

  start-impala-cluster.py --impalad_args=--mem_limit=-1

Checked that the warning showed up in the logs:
  W0808 17:01:36.528360  6251 exec-env.cc:237] Configured with unlimited process memory limit (--mem_limit='-1'). Starting in the next Impala release, a process memory limit must always be specified. See IMPALA-5653.

Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
---
M be/src/runtime/exec-env.cc
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/7622/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5652: deprecate unlimited process mem_limit
......................................................................


IMPALA-5652: deprecate unlimited process mem_limit

Testing:
Started cluster locally with:

  start-impala-cluster.py --impalad_args=--mem_limit=-1

Checked that the warning showed up in the logs:
  W0808 17:01:36.528360  6251 exec-env.cc:237] Configured with unlimited process memory limit (--mem_limit='-1'). Starting in the next Impala release, a process memory limit must always be specified. See IMPALA-5653.

Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
Reviewed-on: http://gerrit.cloudera.org:8080/7622
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/exec-env.cc
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5652: deprecate unlimited process mem_limit
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5652: deprecate unlimited process mem_limit
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5652: deprecate unlimited process mem_limit
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1021/

-- 
To view, visit http://gerrit.cloudera.org:8080/7622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42509a6a9ed49e3752931c82310dfda841dd97df
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No