[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

["Peter Bacsko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759898#comment-16759898 ] 

Peter Bacsko commented on YARN-9266:
------------------------------------

Uploaded first attempt.

Note that the parsing logic was just extracted, but not updated/enhanced in any way. That should be done in YARN-9265.

> Various fixes are needed in IntelFpgaOpenclPlugin
> -------------------------------------------------
>
>                 Key: YARN-9266
>                 URL: https://issues.apache.org/jira/browse/YARN-9266
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9266-001.patch
>
>
> Problems identified in this class:
> * {{InnerShellExecutor}} ignores the timeout parameter
> * {{configureIP()}} uses printStackTrace() instead of logging
> * {{configureIP()}} does not log the output of aocl if the exit code != 0
> * {{parseDiagnoseInfo()}} is too heavyweight -- it should be in its own class for better testability
> * {{downloadIP()}} uses {{contains()}} for file name check -- this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches)
> * method name {{downloadIP()}} is misleading -- it actually tries to finds the file. Everything is downloaded (localized) at this point.
> * {{@VisibleForTesting}} methods should be package private



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org