You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/07 08:48:15 UTC
[GitHub] [kafka] dengziming opened a new pull request #10500: MINOR: Move envelop body request serialize code to RequestContext
dengziming opened a new pull request #10500:
URL: https://github.com/apache/kafka/pull/10500
*More detailed description of your change*
1. Move envelop request body serialize code to `RequestContext `, see https://github.com/apache/kafka/pull/10142#discussion_r606613914
2. Remove `RequestTestUtils.serializeRequestWithHeader` and replace it with request.serializeWithHeader
3. Optimize some code in `RequestConvertToJsonTest`
*Summary of testing strategy (including rationale)*
Unit test for new method
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #10500: MINOR: Move envelop body request serialize code to RequestContext
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10500:
URL: https://github.com/apache/kafka/pull/10500#issuecomment-814747656
This follows our previous discussion, @abbccdda @hachikuji ,PTAL, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #10500: MINOR: Move envelop body request serialize code to RequestContext
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10500:
URL: https://github.com/apache/kafka/pull/10500#issuecomment-819233666
Resolve conflicts and separate this PR into 2 PRs since some codes are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #10500: MINOR: Move envelop body request serialize code to RequestContext
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10500:
URL: https://github.com/apache/kafka/pull/10500#issuecomment-1020820360
ping @abbccdda @hachikuji to have a look when you are free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #10500: MINOR: Move envelop body request serialize code to RequestContext
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10500:
URL: https://github.com/apache/kafka/pull/10500#issuecomment-1020820360
ping @abbccdda @hachikuji to have a look when you are free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org