You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/01 03:00:07 UTC

[GitHub] [incubator-nuttx-apps] CV-Bowen opened a new pull request, #1393: mm_main: delete realloc boundary test

CV-Bowen opened a new pull request, #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393

   ## Summary
   It's better to add DEBUGASSERT in mm code to check the unaligned problem instead add a complex test case.
   
   ## Impact
   no impach
   
   ## Testing
   sim:nsh config mm test pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] CV-Bowen commented on pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#issuecomment-1298025716

   CI Failed and seemed unrelated to this PR.
   ```shell
   ====================================================================================
   Configuration/Tool: nucleo-h743zi2/pysim,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
     Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
     Building NuttX...
     Normalize nucleo-h743zi2/pysim
   72a73
   > CONFIG_POSIX_SPAWN_DEFAULT_STACKSIZE=2048
   75d75
   < CONFIG_POSIX_SPAWN_DEFAULT_STACKSIZE=2048
   Saving the new configuration file
   On branch master
   Your branch is up to date with 'origin/master'.
   
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   boards/arm/stm32h7/nucleo-h743zi2/configs/pysim/defconfig
   
   no changes added to commit (use "git add" and/or "git commit -a")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#discussion_r1010045547


##########
testing/mm/mm_main.c:
##########
@@ -113,8 +113,6 @@ static const int g_alignment2[NTEST_ALLOCS / 2] =
 static FAR void       *g_allocs[NTEST_ALLOCS];
 static struct mallinfo g_alloc_info;
 
-static dq_queue_t g_realloc_queue;

Review Comment:
   remove `#include <mm.h>` at line 35 and search patch from Make.defs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] CV-Bowen commented on pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#issuecomment-1298208726

   Rebased to retrigger the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] CV-Bowen commented on a diff in pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on code in PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#discussion_r1010069749


##########
testing/mm/mm_main.c:
##########
@@ -113,8 +113,6 @@ static const int g_alignment2[NTEST_ALLOCS / 2] =
 static FAR void       *g_allocs[NTEST_ALLOCS];
 static struct mallinfo g_alloc_info;
 
-static dq_queue_t g_realloc_queue;

Review Comment:
   OK, let's do this in next pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#issuecomment-1298055250

   > CI Failed and seemed unrelated to this PR.
   > 
   > ```shell
   > ====================================================================================
   > Configuration/Tool: nucleo-h743zi2/pysim,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   > ------------------------------------------------------------------------------------
   >   Cleaning...
   >   Configuring...
   >   Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   >   Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
   >   Building NuttX...
   >   Normalize nucleo-h743zi2/pysim
   > 72a73
   > > CONFIG_POSIX_SPAWN_DEFAULT_STACKSIZE=2048
   > 75d75
   > < CONFIG_POSIX_SPAWN_DEFAULT_STACKSIZE=2048
   > Saving the new configuration file
   > On branch master
   > Your branch is up to date with 'origin/master'.
   > 
   > Changes not staged for commit:
   >   (use "git add <file>..." to update what will be committed)
   >   (use "git restore <file>..." to discard changes in working directory)
   > 	modified:   boards/arm/stm32h7/nucleo-h743zi2/configs/pysim/defconfig
   > 
   > no changes added to commit (use "git add" and/or "git commit -a")
   > ```
   
   please run:
   ```
   ./tools/refresh.sh --silent nucleo-h743zi2/pysim
   ```
   and send a PR, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#discussion_r1010087864


##########
testing/mm/mm_main.c:
##########
@@ -113,8 +113,6 @@ static const int g_alignment2[NTEST_ALLOCS / 2] =
 static FAR void       *g_allocs[NTEST_ALLOCS];
 static struct mallinfo g_alloc_info;
 
-static dq_queue_t g_realloc_queue;

Review Comment:
   Sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#issuecomment-1298374408

   related patch: https://github.com/apache/incubator-nuttx/pull/7495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1393: mm_main: delete realloc boundary test

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1393:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org