[GitHub] [spark] panbingkun commented on a diff in pull request #41170: [MINOR] Remove redundant character escape "\\" and add UT

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #41170:
URL: https://github.com/apache/spark/pull/41170#discussion_r1193920052


##########
core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala:
##########
@@ -247,7 +247,7 @@ private[spark] class SparkHadoopUtil extends Logging {
     if (isGlobPath(pattern)) globPath(fs, pattern) else Seq(pattern)
   }
 
-  private val HADOOP_CONF_PATTERN = "(\\$\\{hadoopconf-[^\\}\\$\\s]+\\})".r.unanchored

Review Comment:
   Yes, the last } escape is redundant.
   I write other UT as follow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org