You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/11/05 16:27:12 UTC

Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/
-----------------------------------------------------------

Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.


Bugs: MESOS-1894
    https://issues.apache.org/jira/browse/MESOS-1894


Repository: mesos-git


Description
-------

see summary.


Diffs
-----

  src/authentication/cram_md5/authenticator.hpp 601248d 
  src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
  src/tests/module.hpp 7970c28 
  src/tests/module.cpp 482ed22 

Diff: https://reviews.apache.org/r/27619/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Till Toenshoff <to...@me.com>.

> On Nov. 11, 2014, 6:14 a.m., Adam B wrote:
> > src/tests/module.cpp, line 81
> > <https://reviews.apache.org/r/27619/diff/3/?file=755845#file755845line81>
> >
> >     Fix the comment

Argh, these rebases are making me go bannanas :) .... that one slipped in once again - sorry for that.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review60755
-----------------------------------------------------------


On Nov. 9, 2014, 10:14 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 10:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cram_md5_authentication_tests.cpp 1ed2312 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review60755
-----------------------------------------------------------

Ship it!



src/tests/module.cpp
<https://reviews.apache.org/r/27619/#comment102162>

    Fix the comment


- Adam B


On Nov. 9, 2014, 2:14 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 2:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cram_md5_authentication_tests.cpp 1ed2312 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Till Toenshoff <to...@me.com>.

> On Nov. 13, 2014, 1:25 a.m., Adam B wrote:
> > LGTM. I can fix the spacing before committing.

Yes please. I did actually try to follow other examples but didn't check properly enough (obviously) as my checks never really turned up a non trivial forward declaring example. I now looked at process/future.hpp and that one does exactly what you ask for; double-blanks for anything that does possibly contain inner elements (which includes namespaces). We should have an automated rule to prevent me falling into this trap again :)


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review61161
-----------------------------------------------------------


On Nov. 12, 2014, 10:09 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 10:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp a23bf5d 
>   src/tests/cram_md5_authentication_tests.cpp f91f1f9 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review61161
-----------------------------------------------------------

Ship it!


LGTM. I can fix the spacing before committing.


src/authentication/cram_md5/authenticator.hpp
<https://reviews.apache.org/r/27619/#comment102661>

    Should this be double-spaced?



src/authentication/cram_md5/authenticator.hpp
<https://reviews.apache.org/r/27619/#comment102662>

    Shouldn't this be double-spaced?


- Adam B


On Nov. 12, 2014, 2:09 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 2:09 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp a23bf5d 
>   src/tests/cram_md5_authentication_tests.cpp f91f1f9 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 10:09 p.m.)


Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.


Changes
-------

Changed dependency chain and fixed glitch in comment.


Bugs: MESOS-1894
    https://issues.apache.org/jira/browse/MESOS-1894


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  src/authentication/cram_md5/authenticator.hpp a23bf5d 
  src/tests/cram_md5_authentication_tests.cpp f91f1f9 
  src/tests/module.hpp 7970c28 
  src/tests/module.cpp 482ed22 

Diff: https://reviews.apache.org/r/27619/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/
-----------------------------------------------------------

(Updated Nov. 9, 2014, 10:14 p.m.)


Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.


Changes
-------

Rebased against latest authenticator interface changes.


Bugs: MESOS-1894
    https://issues.apache.org/jira/browse/MESOS-1894


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  src/tests/cram_md5_authentication_tests.cpp 1ed2312 
  src/tests/module.hpp 7970c28 
  src/tests/module.cpp 482ed22 

Diff: https://reviews.apache.org/r/27619/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review60243
-----------------------------------------------------------

Ship it!


Ship It!

- Kapil Arya


On Nov. 5, 2014, 7:05 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 7:05 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp 601248d 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 12:05 a.m.)


Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.


Changes
-------

Fixed comment.


Bugs: MESOS-1894
    https://issues.apache.org/jira/browse/MESOS-1894


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  src/authentication/cram_md5/authenticator.hpp 601248d 
  src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
  src/tests/module.hpp 7970c28 
  src/tests/module.cpp 482ed22 

Diff: https://reviews.apache.org/r/27619/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review59965
-----------------------------------------------------------


Patch looks great!

Reviews applied: [27619]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2014, 3:27 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 3:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp 601248d 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Till Toenshoff <to...@me.com>.

> On Nov. 5, 2014, 9:06 p.m., Adam B wrote:
> > src/tests/cram_md5_authentication_tests.cpp, line 211
> > <https://reviews.apache.org/r/27619/diff/1/?file=750292#file750292line211>
> >
> >     Why was this test explicitly creating new CRAMMD5Authenticator instead of using the default initializer with "CRAMMD5Authenticator authenticator;" like the previous tests?
> >     Doesn't seem like it did anything special with the pointer.

IIUC typed tests demand a factory method.


> On Nov. 5, 2014, 9:06 p.m., Adam B wrote:
> > src/tests/module.cpp, line 81
> > <https://reviews.apache.org/r/27619/diff/1/?file=750294#file750294line81>
> >
> >     Fix the comment: "Now add our test Authenticator module"

whoops, will update this in a jiffy.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review60029
-----------------------------------------------------------


On Nov. 5, 2014, 3:27 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 3:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp 601248d 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review60029
-----------------------------------------------------------

Ship it!


Excellent. Elegant and clean. Just update the comment and then we can commit it.


src/tests/cram_md5_authentication_tests.cpp
<https://reviews.apache.org/r/27619/#comment101360>

    Why was this test explicitly creating new CRAMMD5Authenticator instead of using the default initializer with "CRAMMD5Authenticator authenticator;" like the previous tests?
    Doesn't seem like it did anything special with the pointer.



src/tests/module.cpp
<https://reviews.apache.org/r/27619/#comment101364>

    Fix the comment: "Now add our test Authenticator module"


- Adam B


On Nov. 5, 2014, 7:27 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 7:27 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp 601248d 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>