You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sc...@apache.org on 2023/02/27 20:36:31 UTC
[tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 3e08c2790c Have 'pre-release' indicate the the release is in progress.
3e08c2790c is described below
commit 3e08c2790c2eb42e1692841d333ad71f53377086
Author: schultz <sc...@apache.org>
AuthorDate: Mon Feb 27 12:35:49 2023 -0800
Have 'pre-release' indicate the the release is in progress.
This saves one more step in the release process.
---
build.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build.xml b/build.xml
index 27ba36423b..10c63b480f 100644
--- a/build.xml
+++ b/build.xml
@@ -2759,7 +2759,7 @@ asf.ldap.username=${release.asfusername}
<replace file="webapps/docs/changelog.xml"
encoding="UTF-8"
token="rtext="in development""
- value="rtext=""" />
+ value="rtext="Release in progress"" />
</target>
<target name="release"
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Christopher Schultz <ch...@christopherschultz.net>.
All,
On 2/28/23 03:56, Rainer Jung wrote:
> Am 28.02.23 um 09:49 schrieb Mark Thomas:
>> On 28/02/2023 07:22, Rémy Maucherat wrote:
>>> <ch...@christopherschultz.net> wrote:
>>>> On 2/27/23 16:09, Rémy Maucherat wrote:
>>>>> On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
>>>>>> On 27/02/2023 20:36, schultz@apache.org wrote:
>>
>> <snip/>
>>
>>>>>>>
>>>>>>> Have 'pre-release' indicate the the release is in progress.
>>>>>>>
>>>>>>> This saves one more step in the release process.
>>>>>>
>>>>>> I'm not sure we want this in a release tag. Better for it to be
>>>>>> empty.
>>>>>
>>>>> +1, this was on purpose.
>>>>
>>>> This changes the changelog when you do "ant pre-release".
>>>>
>>>> You don't want the release-tag to include "Release in progress"?
>>>> Otherwise it is just blank which is confusing IMHO.
>>>
>>> No, it should be blank. Why would a tagged release be "in progress" ?
>>> When people pull it later from git, it would be done.
>>
>> To add some background to this.
>>
>> I started to add "Release in progress" to the change log for two reasons:
>> - Primarily so there was something in the change log in the docs
>> produced by the CI for the version that was being voted on rather
>> than leaving it empty as that looked odd.
>> - Secondarily to act as a reminder to me to update the change log with
>> the actual release date once the vote finished. A blank release date
>> didn't stand out whereas this text did.
>>
>> My main concern with this change is that when users download a release
>> and look at the change log they will see "Release in progress" for a
>> release that is complete. I think that is much more confusing than the
>> release date being left blank.
>
> +1, it is.
>
>> The official release date is the date that the vote closes. That makes
>> it tricky to include in the tag as we never know exactly how long
>> release votes are going to last. They are typically three working days
>> but that is far from fixed.
>>
>> I try guessing the release date for Commons Daemon and don't think I
>> have ever got it right. I end up correcting the release date of the
>> N-1 release in the N release which I think is potentially even more
>> confusing.
>>
>> Overall, my preference is that:
>> - we leave the release date blank in the tag for that release
>> - we update HEAD to "Release in progress" for that version while voting
>> (probably at the same time as we increment the version number for the
>> next development cycle)
>> - we update HEAD to the actual release date (or "Not released") for that
>> version once the vote completes
>
> +1
>
>> There would certainly be some benefit to automate the second step in
>> the process as a post release task in Ant.
Okay, I'm happy to revert the change, then.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Rainer Jung <ra...@kippdata.de>.
Am 28.02.23 um 09:49 schrieb Mark Thomas:
> On 28/02/2023 07:22, Rémy Maucherat wrote:
>> <ch...@christopherschultz.net> wrote:
>>> On 2/27/23 16:09, Rémy Maucherat wrote:
>>>> On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
>>>>> On 27/02/2023 20:36, schultz@apache.org wrote:
>
> <snip/>
>
>>>>>>
>>>>>> Have 'pre-release' indicate the the release is in progress.
>>>>>>
>>>>>> This saves one more step in the release process.
>>>>>
>>>>> I'm not sure we want this in a release tag. Better for it to be empty.
>>>>
>>>> +1, this was on purpose.
>>>
>>> This changes the changelog when you do "ant pre-release".
>>>
>>> You don't want the release-tag to include "Release in progress"?
>>> Otherwise it is just blank which is confusing IMHO.
>>
>> No, it should be blank. Why would a tagged release be "in progress" ?
>> When people pull it later from git, it would be done.
>
> To add some background to this.
>
> I started to add "Release in progress" to the change log for two reasons:
> - Primarily so there was something in the change log in the docs
> produced by the CI for the version that was being voted on rather
> than leaving it empty as that looked odd.
> - Secondarily to act as a reminder to me to update the change log with
> the actual release date once the vote finished. A blank release date
> didn't stand out whereas this text did.
>
> My main concern with this change is that when users download a release
> and look at the change log they will see "Release in progress" for a
> release that is complete. I think that is much more confusing than the
> release date being left blank.
+1, it is.
> The official release date is the date that the vote closes. That makes
> it tricky to include in the tag as we never know exactly how long
> release votes are going to last. They are typically three working days
> but that is far from fixed.
>
> I try guessing the release date for Commons Daemon and don't think I
> have ever got it right. I end up correcting the release date of the N-1
> release in the N release which I think is potentially even more confusing.
>
> Overall, my preference is that:
> - we leave the release date blank in the tag for that release
> - we update HEAD to "Release in progress" for that version while voting
> (probably at the same time as we increment the version number for the
> next development cycle)
> - we update HEAD to the actual release date (or "Not released") for that
> version once the vote completes
+1
> There would certainly be some benefit to automate the second step in the
> process as a post release task in Ant.
Sure.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Mark Thomas <ma...@apache.org>.
On 28/02/2023 07:22, Rémy Maucherat wrote:
> <ch...@christopherschultz.net> wrote:
>> On 2/27/23 16:09, Rémy Maucherat wrote:
>>> On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
>>>> On 27/02/2023 20:36, schultz@apache.org wrote:
<snip/>
>>>>>
>>>>> Have 'pre-release' indicate the the release is in progress.
>>>>>
>>>>> This saves one more step in the release process.
>>>>
>>>> I'm not sure we want this in a release tag. Better for it to be empty.
>>>
>>> +1, this was on purpose.
>>
>> This changes the changelog when you do "ant pre-release".
>>
>> You don't want the release-tag to include "Release in progress"?
>> Otherwise it is just blank which is confusing IMHO.
>
> No, it should be blank. Why would a tagged release be "in progress" ?
> When people pull it later from git, it would be done.
To add some background to this.
I started to add "Release in progress" to the change log for two reasons:
- Primarily so there was something in the change log in the docs
produced by the CI for the version that was being voted on rather
than leaving it empty as that looked odd.
- Secondarily to act as a reminder to me to update the change log with
the actual release date once the vote finished. A blank release date
didn't stand out whereas this text did.
My main concern with this change is that when users download a release
and look at the change log they will see "Release in progress" for a
release that is complete. I think that is much more confusing than the
release date being left blank.
The official release date is the date that the vote closes. That makes
it tricky to include in the tag as we never know exactly how long
release votes are going to last. They are typically three working days
but that is far from fixed.
I try guessing the release date for Commons Daemon and don't think I
have ever got it right. I end up correcting the release date of the N-1
release in the N release which I think is potentially even more confusing.
Overall, my preference is that:
- we leave the release date blank in the tag for that release
- we update HEAD to "Release in progress" for that version while voting
(probably at the same time as we increment the version number for the
next development cycle)
- we update HEAD to the actual release date (or "Not released") for that
version once the vote completes
There would certainly be some benefit to automate the second step in the
process as a post release task in Ant.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 28, 2023 at 1:46 AM Christopher Schultz
<ch...@christopherschultz.net> wrote:
>
> Mark and Remy,
>
> On 2/27/23 16:09, Rémy Maucherat wrote:
> > On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
> >>
> >> On 27/02/2023 20:36, schultz@apache.org wrote:
> >>> This is an automated email from the ASF dual-hosted git repository.
> >>>
> >>> schultz pushed a commit to branch 10.1.x
> >>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>>
> >>>
> >>> The following commit(s) were added to refs/heads/10.1.x by this push:
> >>> new 3e08c2790c Have 'pre-release' indicate the the release is in progress.
> >>> 3e08c2790c is described below
> >>>
> >>> commit 3e08c2790c2eb42e1692841d333ad71f53377086
> >>> Author: schultz <sc...@apache.org>
> >>> AuthorDate: Mon Feb 27 12:35:49 2023 -0800
> >>>
> >>> Have 'pre-release' indicate the the release is in progress.
> >>>
> >>> This saves one more step in the release process.
> >>
> >> I'm not sure we want this in a release tag. Better for it to be empty.
> >
> > +1, this was on purpose.
>
> This changes the changelog when you do "ant pre-release".
>
> You don't want the release-tag to include "Release in progress"?
> Otherwise it is just blank which is confusing IMHO.
No, it should be blank. Why would a tagged release be "in progress" ?
When people pull it later from git, it would be done.
> Whenever I do a release, I put "Release in progress" into the rtext in
> the changelog. I can stop doing that if you would prefer.
Rémy
>
> -chris
>
> >>> ---
> >>> build.xml | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/build.xml b/build.xml
> >>> index 27ba36423b..10c63b480f 100644
> >>> --- a/build.xml
> >>> +++ b/build.xml
> >>> @@ -2759,7 +2759,7 @@ asf.ldap.username=${release.asfusername}
> >>> <replace file="webapps/docs/changelog.xml"
> >>> encoding="UTF-8"
> >>> token="rtext="in development""
> >>> - value="rtext=""" />
> >>> + value="rtext="Release in progress"" />
> >>> </target>
> >>>
> >>> <target name="release"
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark and Remy,
On 2/27/23 16:09, Rémy Maucherat wrote:
> On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
>>
>> On 27/02/2023 20:36, schultz@apache.org wrote:
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> schultz pushed a commit to branch 10.1.x
>>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/10.1.x by this push:
>>> new 3e08c2790c Have 'pre-release' indicate the the release is in progress.
>>> 3e08c2790c is described below
>>>
>>> commit 3e08c2790c2eb42e1692841d333ad71f53377086
>>> Author: schultz <sc...@apache.org>
>>> AuthorDate: Mon Feb 27 12:35:49 2023 -0800
>>>
>>> Have 'pre-release' indicate the the release is in progress.
>>>
>>> This saves one more step in the release process.
>>
>> I'm not sure we want this in a release tag. Better for it to be empty.
>
> +1, this was on purpose.
This changes the changelog when you do "ant pre-release".
You don't want the release-tag to include "Release in progress"?
Otherwise it is just blank which is confusing IMHO.
Whenever I do a release, I put "Release in progress" into the rtext in
the changelog. I can stop doing that if you would prefer.
-chris
>>> ---
>>> build.xml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/build.xml b/build.xml
>>> index 27ba36423b..10c63b480f 100644
>>> --- a/build.xml
>>> +++ b/build.xml
>>> @@ -2759,7 +2759,7 @@ asf.ldap.username=${release.asfusername}
>>> <replace file="webapps/docs/changelog.xml"
>>> encoding="UTF-8"
>>> token="rtext="in development""
>>> - value="rtext=""" />
>>> + value="rtext="Release in progress"" />
>>> </target>
>>>
>>> <target name="release"
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Rémy Maucherat <re...@apache.org>.
On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
>
> On 27/02/2023 20:36, schultz@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > schultz pushed a commit to branch 10.1.x
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The following commit(s) were added to refs/heads/10.1.x by this push:
> > new 3e08c2790c Have 'pre-release' indicate the the release is in progress.
> > 3e08c2790c is described below
> >
> > commit 3e08c2790c2eb42e1692841d333ad71f53377086
> > Author: schultz <sc...@apache.org>
> > AuthorDate: Mon Feb 27 12:35:49 2023 -0800
> >
> > Have 'pre-release' indicate the the release is in progress.
> >
> > This saves one more step in the release process.
>
> I'm not sure we want this in a release tag. Better for it to be empty.
+1, this was on purpose.
Rémy
>
> Mark
>
> > ---
> > build.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/build.xml b/build.xml
> > index 27ba36423b..10c63b480f 100644
> > --- a/build.xml
> > +++ b/build.xml
> > @@ -2759,7 +2759,7 @@ asf.ldap.username=${release.asfusername}
> > <replace file="webapps/docs/changelog.xml"
> > encoding="UTF-8"
> > token="rtext="in development""
> > - value="rtext=""" />
> > + value="rtext="Release in progress"" />
> > </target>
> >
> > <target name="release"
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.
Posted by Mark Thomas <ma...@apache.org>.
On 27/02/2023 20:36, schultz@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> schultz pushed a commit to branch 10.1.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/10.1.x by this push:
> new 3e08c2790c Have 'pre-release' indicate the the release is in progress.
> 3e08c2790c is described below
>
> commit 3e08c2790c2eb42e1692841d333ad71f53377086
> Author: schultz <sc...@apache.org>
> AuthorDate: Mon Feb 27 12:35:49 2023 -0800
>
> Have 'pre-release' indicate the the release is in progress.
>
> This saves one more step in the release process.
I'm not sure we want this in a release tag. Better for it to be empty.
Mark
> ---
> build.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.xml b/build.xml
> index 27ba36423b..10c63b480f 100644
> --- a/build.xml
> +++ b/build.xml
> @@ -2759,7 +2759,7 @@ asf.ldap.username=${release.asfusername}
> <replace file="webapps/docs/changelog.xml"
> encoding="UTF-8"
> token="rtext="in development""
> - value="rtext=""" />
> + value="rtext="Release in progress"" />
> </target>
>
> <target name="release"
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org