You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "rodrigonull (via GitHub)" <gi...@apache.org> on 2024/01/03 19:46:01 UTC
[PR] kie-issues#802: KIE Sandbox Helm Chart staging, release and publish Jenkins jobs [incubator-kie-tools]
rodrigonull opened a new pull request, #2107:
URL: https://github.com/apache/incubator-kie-tools/pull/2107
This PR adds a new Jenkins job as part of the KIE Tools release process to push the KIE Sandbox helm chart to quay.io registry. It also pushes the prerelease version of the chart as part of the staging Jenkins job.
This PR updates the main chart name to replace the underscore "_" to dash "-" to make the repository name consistent in the registry.
The PR also addresses some minor fixes for the chart installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#802: KIE Sandbox Helm Chart staging, release and publish Jenkins jobs [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2107:
URL: https://github.com/apache/incubator-kie-tools/pull/2107#discussion_r1440894437
##########
.ci/jenkins/Jenkinsfile.staging-build:
##########
@@ -795,6 +801,23 @@ pipeline {
}
}
}
+
+ stage('STAGING: Push kie-sandbox-helm-chart to quay.io') {
+ when {
+ expression { !params.DRY_RUN }
+ }
+ steps {
+ dir('kie-tools') {
+ script {
+ helmUtils.pushChartToRegistry(
+ "${env.KIE_SANDBOX_HELM_CHART__registry}/${env.KIE_SANDBOX_HELM_CHART__account}",
+ "packages/${env.KIE_SANDBOX_HELM_CHART__name}/dist/${env.KIE_SANDBOX_HELM_CHART__name}-${env.KIE_SANDBOX_HELM_CHART__tag}.tgz",
Review Comment:
```suggestion
"packages/kie-sandbox-helm-chart/dist/${env.KIE_SANDBOX_HELM_CHART__name}-${env.KIE_SANDBOX_HELM_CHART__tag}.tgz",
```
The package name won't change based on the environment variable.
##########
.ci/jenkins/release-jobs/Jenkinsfile.kie-sandbox-helm-chart:
##########
@@ -113,6 +118,22 @@ pipeline {
}
}
+ stage('Push kie-sandbox-helm-chart to quay.io') {
+ when {
+ expression { !params.DRY_RUN }
+ }
+ steps {
+ dir('kie-tools') {
+ script {
+ helmUtils.pushChartToRegistry(
+ "${env.KIE_SANDBOX_HELM_CHART__registry}/${env.KIE_SANDBOX_HELM_CHART__account}",
+ "packages/${env.KIE_SANDBOX_HELM_CHART__name}/dist/${env.KIE_SANDBOX_HELM_CHART__name}-${env.KIE_SANDBOX_HELM_CHART__tag}.tgz",
Review Comment:
```suggestion
"packages/kie-sandbox-helm-chart/dist/${env.KIE_SANDBOX_HELM_CHART__name}-${env.KIE_SANDBOX_HELM_CHART__tag}.tgz",
```
Same thing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#802: KIE Sandbox Helm Chart staging, release and publish Jenkins jobs [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2107:
URL: https://github.com/apache/incubator-kie-tools/pull/2107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org