You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by tc...@apache.org on 2014/03/07 23:37:30 UTC
svn commit: r1575440 - in
/maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner:
AbstractJarsignerMojo.java JarsignerSignMojo.java
Author: tchemit
Date: Fri Mar 7 22:37:29 2014
New Revision: 1575440
URL: http://svn.apache.org/r1575440
Log:
MJARSIGNER-34 - The 'verify' goal of the plugin is passing '-keystore' but not '-storetype'.
Add also provider* parameter for both sign and verify mojo
Modified:
maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java
maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java
Modified: maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java?rev=1575440&r1=1575439&r2=1575440&view=diff
==============================================================================
--- maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java (original)
+++ maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java Fri Mar 7 22:37:29 2014
@@ -85,6 +85,24 @@ public abstract class AbstractJarsignerM
/**
* See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
*/
+ @Parameter( property = "jarsigner.providerName" )
+ private String providerName;
+
+ /**
+ * See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
+ */
+ @Parameter( property = "jarsigner.providerClass" )
+ private String providerClass;
+
+ /**
+ * See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
+ */
+ @Parameter( property = "jarsigner.providerArg" )
+ private String providerArg;
+
+ /**
+ * See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
+ */
@Parameter( property = "jarsigner.alias" )
private String alias;
@@ -469,6 +487,9 @@ public abstract class AbstractJarsignerM
request.setArchive( archive );
request.setKeystore( keystore );
request.setStoretype( storetype );
+ request.setProviderArg( providerArg );
+ request.setProviderClass( providerClass );
+ request.setProviderName( providerName );
request.setWorkingDirectory( workingDirectory );
request.setMaxMemory( maxMemory );
request.setArguments( arguments );
Modified: maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java?rev=1575440&r1=1575439&r2=1575440&view=diff
==============================================================================
--- maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java (original)
+++ maven/plugins/trunk/maven-jarsigner-plugin/src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java Fri Mar 7 22:37:29 2014
@@ -57,24 +57,6 @@ public class JarsignerSignMojo
private String sigfile;
/**
- * See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
- */
- @Parameter( property = "jarsigner.providerName" )
- private String providerName;
-
- /**
- * See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
- */
- @Parameter( property = "jarsigner.providerClass" )
- private String providerClass;
-
- /**
- * See <a href="http://java.sun.com/javase/6/docs/technotes/tools/windows/jarsigner.html#Options">options</a>.
- */
- @Parameter( property = "jarsigner.providerArg" )
- private String providerArg;
-
- /**
* Indicates whether existing signatures should be removed from the processed JAR files prior to signing them. If
* enabled, the resulting JAR will appear as being signed only once.
*
@@ -136,9 +118,6 @@ public class JarsignerSignMojo
throws MojoExecutionException
{
JarSignerSignRequest request = new JarSignerSignRequest();
- request.setProviderArg( providerArg );
- request.setProviderClass( providerClass );
- request.setProviderName( providerName );
request.setSigfile( sigfile );
request.setTsaLocation( tsa );
request.setTsaAlias( tsacert );