You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/07/31 14:20:57 UTC
[isis] branch master updated: ISIS-2794: comments on PRE_COMMIT
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 10017db ISIS-2794: comments on PRE_COMMIT
10017db is described below
commit 10017db4a151aebe94d59a2654665826a343c972
Author: Andi Huber <ah...@apache.org>
AuthorDate: Sat Jul 31 16:20:36 2021 +0200
ISIS-2794: comments on PRE_COMMIT
---
.../publishing/LifecycleEventPublishingTestAbstract.java | 12 ++++++++----
.../isis/testdomain/publishing/PublishingTestFactoryJpa.java | 4 ++++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/regressiontests/incubating/src/test/java/org/apache/isis/testdomain/publishing/LifecycleEventPublishingTestAbstract.java b/regressiontests/incubating/src/test/java/org/apache/isis/testdomain/publishing/LifecycleEventPublishingTestAbstract.java
index 38d9667..d69679a 100644
--- a/regressiontests/incubating/src/test/java/org/apache/isis/testdomain/publishing/LifecycleEventPublishingTestAbstract.java
+++ b/regressiontests/incubating/src/test/java/org/apache/isis/testdomain/publishing/LifecycleEventPublishingTestAbstract.java
@@ -107,14 +107,18 @@ extends PublishingTestAbstract {
case PROPERTY_UPDATE: // update the book's name -> "Book #2"
- //assertHasUpdatingLifecycleEvents(bookSample2); //FIXME PRE_COMMIT triggered too early?
- //assertHasUpdatedLifecycleEvents(Can.empty()); //TODO what is expected empty or not?
+ //XXX if we want to trigger callback events before PRE_COMMIT then changes need to be flushed .eg
+ //val em = jpaSupport.getEntityManagerElseFail(JpaBook.class);
+ //em.flush(); // in effect makes changes visible during PRE_COMMIT
+ //assertHasUpdatingLifecycleEvents(bookSample2);
+
+ //assertHasUpdatedLifecycleEvents(Can.empty()); //XXX only empty if not flushed
return;
case ACTION_INVOCATION: // double the book's price action -> 198.0
- //assertHasUpdatingLifecycleEvents(bookSample3);//FIXME PRE_COMMIT triggered too early?
- //assertHasUpdatedLifecycleEvents(Can.empty()); //TODO what is expected empty or not?
+ //assertHasUpdatingLifecycleEvents(bookSample3); //XXX only populated if flushed
+ //assertHasUpdatedLifecycleEvents(Can.empty()); //XXX only empty if not flushed
return;
case ENTITY_REMOVAL:
diff --git a/regressiontests/stable/src/main/java/org/apache/isis/testdomain/publishing/PublishingTestFactoryJpa.java b/regressiontests/stable/src/main/java/org/apache/isis/testdomain/publishing/PublishingTestFactoryJpa.java
index 1ee6620..b7c1b04 100644
--- a/regressiontests/stable/src/main/java/org/apache/isis/testdomain/publishing/PublishingTestFactoryJpa.java
+++ b/regressiontests/stable/src/main/java/org/apache/isis/testdomain/publishing/PublishingTestFactoryJpa.java
@@ -426,9 +426,13 @@ extends PublishingTestFactoryAbstract {
@SneakyThrows
private void withBookDo(final CheckedConsumer<JpaBook> bookConsumer) {
+ //val em = jpaSupport.getEntityManagerElseFail(JpaBook.class);
+
val book = repository.allInstances(JpaBook.class).listIterator().next();
bookConsumer.accept(book);
+ //em.flush(); // in effect makes changes visible during PRE_COMMIT
+
}