You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/14 09:54:58 UTC
[GitHub] [airflow] ashb opened a new pull request, #26389: Better validation of Dataset URI during dag parse
ashb opened a new pull request, #26389:
URL: https://github.com/apache/airflow/pull/26389
Previously we had the validation on the Dataset model, but we since moved the "dag" facing class to a separate one. This adds validation to the public class, and extends the validation to not allow space-only strings
Closes #26380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246600267
Oh, those are testing the public dataset class, not the model. Yeah I'll remove those tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
kaxil commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246968812
The failure is due to https://github.com/apache/airflow/pull/26382 I think -- where we forgot to add it to rat_exclude?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246993103
https://github.com/apache/airflow/pull/26396 to fix main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246992499
Failure is on main, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246595219
> Might be worth retiring `tests/models/test_dataset.py` as part of this?
I considered that, but we do still have validation on the model -- should we keep that or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246977127
> The failure is due to #26382 I think -- where we forgot to add it to rat_exclude?
Yep, unrelated to this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
ashb merged PR #26389:
URL: https://github.com/apache/airflow/pull/26389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] norm commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
norm commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246535419
Might be worth retiring `tests/models/test_dataset.py` as part of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #26389: Better validation of Dataset URI during dag parse
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #26389:
URL: https://github.com/apache/airflow/pull/26389#issuecomment-1246737850
Fail Ash. (New dev env, don't have pre-commit set up there yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org