You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/09/12 20:54:34 UTC

[jira] [Commented] (CB-7538) Beep in Android locks main UI thread

    [ https://issues.apache.org/jira/browse/CB-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131932#comment-14131932 ] 

ASF GitHub Bot commented on CB-7538:
------------------------------------

GitHub user dpeacock opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/33

    CB-7538 Android beep thread fix

    Beep now executes in it's own thread.  It was previously executing in the main UI thread which was causing the application to lock up will the beep was occurring.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpeacock/cordova-plugin-dialogs CB-7538

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit 0b4afee46d9d095ca956cb6e3f0a92a828d02f91
Author: David Peacock <da...@gmail.com>
Date:   2014-09-12T18:52:01Z

    CB-7538 Android beep thread fix
    Beep now executes in it's own thread.  It was previously executing in the main UI thread which was causing the application to lock up will the beep was occurring.

----


> Beep in Android locks main UI thread
> ------------------------------------
>
>                 Key: CB-7538
>                 URL: https://issues.apache.org/jira/browse/CB-7538
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Dialogs
>            Reporter: David Peacock
>
> When using the navigator.notification.beep() the main UI thread gets locked up.  This is especially noticeable when you have a long notification ringtone, or are calling beep with a parameter (i.e. beep(10)).  Beep should be done in it's own thread.
> I will be submitting a pull request that resolves this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)