You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/01/24 22:36:32 UTC
Change in asterixdb-clients[master]: [NO ISSUE] Set localhost as default for 'server' field
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964 )
Change subject: [NO ISSUE] Set localhost as default for 'server' field
......................................................................
[NO ISSUE] Set localhost as default for 'server' field
Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
---
M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-clients refs/changes/64/14964/1
diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
index c7e9a06..dde677d 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
+++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
@@ -18,7 +18,7 @@
!-->
<connection-fields>
- <field name="server" label="Server" category="endpoint" value-type="string">
+ <field name="server" label="Server" category="endpoint" value-type="string" default-value="localhost">
<validation-rule reg-exp="^[^/]+$"/>
</field>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-MessageType: newchange
Change in asterixdb-clients[master]: [NO ISSUE] Set localhost as default for 'server' field
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964 )
Change subject: [NO ISSUE] Set localhost as default for 'server' field
......................................................................
[NO ISSUE] Set localhost as default for 'server' field
Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
Reviewed-by: Ian Maxon <im...@uci.edu>
---
M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ian Maxon: Looks good to me, approved
Dmitry Lychagin: Looks good to me, but someone else must approve
Jenkins: Verified
diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
index c7e9a06..dde677d 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
+++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
@@ -18,7 +18,7 @@
!-->
<connection-fields>
- <field name="server" label="Server" category="endpoint" value-type="string">
+ <field name="server" label="Server" category="endpoint" value-type="string" default-value="localhost">
<validation-rule reg-exp="^[^/]+$"/>
</field>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-MessageType: merged
Change in asterixdb-clients[master]: [NO ISSUE] Set localhost as default for 'server' field
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964 )
Change subject: [NO ISSUE] Set localhost as default for 'server' field
......................................................................
[NO ISSUE] Set localhost as default for 'server' field
Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
---
M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-clients refs/changes/64/14964/1
diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
index c7e9a06..dde677d 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
+++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
@@ -18,7 +18,7 @@
!-->
<connection-fields>
- <field name="server" label="Server" category="endpoint" value-type="string">
+ <field name="server" label="Server" category="endpoint" value-type="string" default-value="localhost">
<validation-rule reg-exp="^[^/]+$"/>
</field>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-MessageType: newchange
Change in asterixdb-clients[master]: [NO ISSUE] Set localhost as default for 'server' field
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964 )
Change subject: [NO ISSUE] Set localhost as default for 'server' field
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Mon, 24 Jan 2022 23:17:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb-clients[master]: [NO ISSUE] Set localhost as default for 'server' field
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ian Maxon <im...@uci.edu>:
Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964 )
Change subject: [NO ISSUE] Set localhost as default for 'server' field
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/14964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: I535b84df9dc84c00dba33a01fcf2a4c678018ef4
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Mon, 24 Jan 2022 23:36:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment