You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@drill.apache.org by "Paul Rogers (JIRA)" <ji...@apache.org> on 2018/04/19 20:36:00 UTC

[jira] [Commented] (DRILL-6343) bit vector copyFromSafe is not doing realloc

    [ https://issues.apache.org/jira/browse/DRILL-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444749#comment-16444749 ] 

Paul Rogers commented on DRILL-6343:
------------------------------------

The bit vector is deprecated and likely badly broken. We are using `UInt1Vector` in place of `BitVector`.

> bit vector copyFromSafe is not doing realloc 
> ---------------------------------------------
>
>                 Key: DRILL-6343
>                 URL: https://issues.apache.org/jira/browse/DRILL-6343
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.13.0
>            Reporter: Padma Penumarthy
>            Assignee: Padma Penumarthy
>            Priority: Major
>             Fix For: 1.14.0
>
>
> bit vector copyFromSafe simply returns false when asked to copy to an index greater than it's capacity. It should do realloc if needed and copy correctly.
> This bug is very subtle and shows up as random wrong result. allocateNew for bit vector allocates 4096 bytes initially and if we do copyFromSafe to any index greater than that, we basically do not do any copy, but just return false. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)