[jira] [Commented] (ORC-946) Unified json library

["Dongjoon Hyun (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399288#comment-17399288 ] 

Dongjoon Hyun commented on ORC-946:
-----------------------------------

Thank you for filing a JIRA issue, [~Guiyankuang].
1. I'm okay for the unification.
2. Have you compare them? Which one is the most popular?

cc [~omalley], [~pgaref], [~william]


> Unified json library
> --------------------
>
>                 Key: ORC-946
>                 URL: https://issues.apache.org/jira/browse/ORC-946
>             Project: ORC
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 1.8.0
>            Reporter: Yiqun Zhang
>            Assignee: Yiqun Zhang
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> The java project depends on several json libraries, can we unify them into one so that we can also reduce the dependencies.
> use jackson-core in orc-benchmarks-core
>  org.apache.orc.bench.core.convert.json.JsonReader
>  org.apache.orc.bench.core.convert.json.JsonWriter
> use gson in tools
>  org.apache.orc.tools.convert.JsonReader
>  org.apache.orc.tools.json.JsonSchemaFinder
>  org.apache.orc.tools.json.JsonShredder
>  org.apache.orc.tools.json.TestJsonSchemaFinder
> use jettjson in tools
>  org.apache.orc.tools.KeyTool
>  org.apache.orc.tools.JsonFileDump
>  org.apache.orc.tools.PrintData
>  
> I could provide a pr to unify the json library. But I'd like to hear from people
> 1. is the unification necessary?
> 2. if so, which library do we use? jackson/gson/jettison
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)