You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/11/17 22:11:42 UTC

[GitHub] [incubator-hudi] vinothchandar edited a comment on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient

vinothchandar edited a comment on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-554793080
 
 
   >One that takes in HoodieKeys and another that takes in HoodieRecords.
   
   I don't recall this. If we had just the one that takes `HoodieKey`s, that should be sufficient to build the data source and deltastremer changer?
   
   If the source hands `HoodieRecord`s, then  users needs to handle this differently, via the Payload implemenetation.. We should support a `DELETE` operation on the HoodieDeltaStreamer similar to datasource for this JIRA. And that should be sufficient.. 
   
   @bvaradar  said he will do this review for this one :).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services