[GitHub] jdye64 commented on a change in pull request #487: POC: MINIFICPP-738 - EL should be able to access global properties

[GitBox <gi...@apache.org>]

jdye64 commented on a change in pull request #487: POC: MINIFICPP-738 - EL should be able to access global properties
URL: https://github.com/apache/nifi-minifi-cpp/pull/487#discussion_r257873573
 
 

 ##########
 File path: libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp
 ##########
 @@ -203,6 +209,12 @@ TEST_CASE("GetFile PutFile dynamic attribute", "[expressionLanguageTestGetFilePu
       get_file,
       processors::GetFile::KeepSourceFile.getName(),
       "false");
+  auto update = plan->addProcessor(
+      "UpdateAttribute",
+      "UpdateAttribute",
+      core::Relationship("success", "description"),
+      true);
+  update->setDynamicProperty("prop_attr", "${'nifi.my.own.property'}_added");
 
 Review comment:
   Yes it is. However I just want to make sure we document that those global properties must start with "nifi." could we add that to the documentation somewhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services