You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/01 19:05:36 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #6430: Filter removed nics while listing LB vm instances
GutoVeronezi opened a new pull request, #6430:
URL: https://github.com/apache/cloudstack/pull/6430
### Description
When we remove the NIC of a network from a VM and add a new NIC of the same network, we will have two registers in the database for the same VM and network, one of them being marked as `removed`. In API `listLoadBalancerRuleInstances`, specifically in the method `LoadBalancingRulesManagerImpl#listLoadBalancerInstances`, ACS retrieves the instances according to the user's account and the network where the LB is being created; however, it lists all the NICs, even the marked as `removed`, which causes the following error while listing the VMs:
```
2022-05-16 14:06:32,859 ERROR [c.c.a.ApiServer] (qtp365590665-27:ctx-5ce79f30 ctx-9de90969) (logid:a3518976) unhandled exception executing api command: [Ljava.lang.String;@55d45499
java.lang.IndexOutOfBoundsException: Index 2 out of bounds for length 2
```
This PR intends to fix this error by filtering the removed NICs while listing the LB intances.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ x] Minor
- [ ] Trivial
### How Has This Been Tested?
In a local lab, I created a VM with a random network. I added a NIC for a specific network (`test`) to the VM. I removed the NIC of network `test` and then added it again. I created a LB rule with this VM. Before the changes, while listing the LB rule instances I got `Index 1 out of bounds for length 1`. After the changes, the instance was listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1175792578
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144028403
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1180211797
I was able to reproduce the issue and tested the fix also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1176426739
<b>Trillian test result (tid-4433)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38419 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6430-t4433-kvm-centos7.zip
Smoke tests completed. 94 look OK, 4 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.59 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.20 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 28.92 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 65.61 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 37.99 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 37.96 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 123.49 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 155.58 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 269.05 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 143.87 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.73 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.79 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144074955
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6430)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6430&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6430&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6430&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1171239931
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1178135364
<b>Trillian test result (tid-4440)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41192 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6430-t4440-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_arping_in_ssvm | `Failure` | 5.17 | test_diagnostics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1149335840
Hi @GutoVeronezi can you please target this fix to the 4.17 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1170823985
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1171155280
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1175756776
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144440505
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144028047
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144443138
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144480364
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1175756976
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161742471
> Hi @GutoVeronezi can you please target this fix to the 4.17 branch?
Hi @nvazquez, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1171078560
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1171156844
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1177210176
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala merged pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala merged PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1175792793
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1170824791
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144035091
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6430 (SL-JID-1657)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1175435487
@sureshanaparti could we run the tests again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1177210453
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144443436
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144490189
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161758141
> code looks good @GutoVeronezi , but did you check if the list is retrieved in other places as well? I agree it should work like this and if removed nics should be retrieved as well a method like `listNicsIncludingRomoved()`. This is not always implemented this way so care must be taken.
Hi @DaanHoogland,
`nicSearch` is declared in the method scope and is only used by `AccountDataCenterVirtualSearch`, which is only used by the method `listVirtualNetworkInstancesByAcctAndNetwork`, which is only called in the API `listLoadBalancerRuleInstances` workflow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161755259
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6430 (SL-JID-1793)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161744495
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161743134
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161823467
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6430)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6430&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6430&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6430&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6430&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6430&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161966501
> > code looks good @GutoVeronezi , but did you check if the list is retrieved in other places as well? I agree it should work like this and if removed nics should be retrieved as well a method like `listNicsIncludingRomoved()`. This is not always implemented this way so care must be taken.
>
> Hi @DaanHoogland,
>
> `nicSearch` is declared in the method's scope and is only used by `AccountDataCenterVirtualSearch`, which is only used by the method `listVirtualNetworkInstancesByAcctAndNetwork`, which is only called in the API `listLoadBalancerRuleInstances` workflow:
>
> 
>
>
Ok, than renaming to `listNicsIncluding removed()` or not is free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1175785833
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1145177234
<b>Trillian test result (tid-4279)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41001 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6430-t4279-kvm-centos7.zip
Smoke tests completed. 96 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 461.16 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6430: Filter removed nics while listing LB vm instances
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6430:
URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1144494734
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org