You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/07/24 20:59:15 UTC
(superset) branch theme_crud updated (deb00c9b51 -> a195b9076f)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a change to branch theme_crud
in repository https://gitbox.apache.org/repos/asf/superset.git
discard deb00c9b51 better height/scrolling and some ES6 stuff
discard b5d8051a81 fix form to align with styling best-practices
discard 609daebd20 pylint
discard b1bc01cdd1 eslint
discard fa5d64645e Kill redundant feature flag
discard 504c810002 UX tweaks, verbage
discard 5040958b68 import functionality
discard 88e7c3452d fix bolts
discard 8f2421fa7a tackling
discard f04ac2001e remove uuid complexity from config
discard 310eb31afc removed priority 2
discard 3fc237460a fix urls / refresh page when on
discard cb3c8dd57e Update superset-frontend/src/components/ListView/Filters/Search.tsx
discard 6656043569 Update .gitignore
discard 2b0776bb17 converting class->functional components so they can use useTheme()
discard acf1fdb3b4 fix UX issues/bugs
discard b32ad403a2 fix 2 unit tests
discard 97708b6beb fix a test
discard 29a9574e1e fixed types
discard 92bd2a0ba2 bump nvm
discard 43fa1189be no global themeobject
discard c55cc80101 todo tackle
discard 3bb20633e4 more thunder icons
discard 915eadfe19 improve the mode selector
discard 20236a2ee8 docs and pointers to it
discard 941dfff66e fix circular imports
discard b386f2828c iterating on LLMS.md
discard 8d5832680d fix more backend tests
discard 10cb0746ea fixing tests
discard f5c929fc98 fix types
discard a82cd9848c Apply button secondary
discard fd559c3060 helpful tooltips
discard a4a2a40c7e Alert in theme deletion
discard d00480fb03 allow deleting and clean up fks
discard 3ca86ef2b3 touchups
discard 6d5f0534d3 delete themes
discard f8a93a7005 extra logic for themes set as pointers to other ones
discard 1de4ffac1a update tests
discard 005b697e78 --reports=no
discard 98ca15e554 touchups
discard f438c56c27 better theme defaults
discard bfe1e9ce2d rm Basic information
discard 033ded70ca system themes
discard e188a19bfa address PR comments about using migrations utils
discard e15e135d56 fix a test
discard c4e2ddfb6e fix one more test
discard 755d384364 fixed python tests
discard a8fe2c0383 fix migration for sqlite
discard 01d53e347e fix 3 unit tests
discard 7b639cd2ff tsc
discard 1519978cb0 export
discard 7299249dff tests + lint
discard 46da149871 can apply and fix unit tests
discard 7d8e8d5913 alter UI to enable associating a theme to a dashboard
discard 1f880fb11e add theme_id to the dashboard apis
discard f4e84d2d6f finalizing CRUD, removing navbar feature flag
discard 443157aef1 feat: add a theme CRUD page to manage themes
add 9c6271136d fix(theming): Visual regressions p2 (#34279)
add 11324607d0 fix: Bulk select is not respecting the TAGGING_SYSTEM feature flag (#34282)
add 710c277681 style(Button): Vertically align icons across all buttons (#34067)
add 32f8f33a4f fix(deckgl): fix deck.gl color breakpoints Control (#34244)
add 77ffe65773 chore(deps): bump axios from 1.10.0 to 1.11.0 in /docs (#34285)
add 9099b0f00d fix: fix the pre-commit hook for tsc (#34275)
add 43775e9373 fix(sqllab_export): manually encode CSV output to support utf-8-sig (#34235)
add 800c1639ec chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend (#33997)
add 9b88527883 chore: remove supposedly dev dep `html-webpack-plugin` from lockfile (#34288)
add 1e5a4e9bdc fix: Saved queries list break if one query can't be parsed (#34289)
add 7a1c056374 fix(charting): correctly categorize numeric columns with NULL values (#34213)
add da55a6c94a fix(chart-download): ensure full table or handlebar chart is captured in image export (#34233)
add c99843b13a fix: Hide View in SQL Lab for users without access (#34293)
add ab59b7e9b0 feat: make `SupersetClient` retry on 502-504 (#34290)
add efa8cb6fa4 chore: improve sqlglot parsing (#34270)
add 3f8472ca7b chore: move some rules from ruff -> pylint (#34292)
add 30e5684006 fix: address numerous long-standing console errors (python & web) (#34299)
add 89bf77b5c9 fix(theming): Fix visual regressions from theming P7 (#34237)
add 3177131d52 feat: re-order CRUD list view action buttons (#34294)
add b794b192d1 fix: return 422 on invalid SQL (#34303)
add 4ec40c0363 feat: add a theme CRUD page to manage themes
add b553f94988 finalizing CRUD, removing navbar feature flag
add 505b548b7d add theme_id to the dashboard apis
add 83715c7661 alter UI to enable associating a theme to a dashboard
add c5734de24a can apply and fix unit tests
add 1e3bf22214 tests + lint
add 01d88296ef export
add 240f084d80 tsc
add f89eed4536 fix 3 unit tests
add 1503c45da7 fix migration for sqlite
add 7efb966956 fixed python tests
add f37a4720bf fix one more test
add 36a65b2063 fix a test
add 1105c28f03 address PR comments about using migrations utils
add 9f344b4d0d system themes
add 433713628d rm Basic information
add 55fc0f1cea better theme defaults
add 58772cea03 touchups
add c78bcdf994 --reports=no
add dd0cc59ebe update tests
add eb7826a6aa extra logic for themes set as pointers to other ones
add f524d81487 delete themes
add ece849f495 touchups
add a9fcd895e7 allow deleting and clean up fks
add ba5fa37de0 Alert in theme deletion
add 567d160ec5 helpful tooltips
add dadbac6578 Apply button secondary
add 511dfc822a fix types
add c65cae52a3 fixing tests
add e09a8dd92d fix more backend tests
add a212c15665 iterating on LLMS.md
add 5812ef1e7f fix circular imports
add acc19a0430 docs and pointers to it
add 39002dae6c improve the mode selector
add 8681d71d23 more thunder icons
add 1fa3f2ef18 todo tackle
add 3113f33ce3 no global themeobject
add 0a8a3fa045 bump nvm
add fa7740a56f fixed types
add a3d0d5e677 fix a test
add 22db00bd31 fix 2 unit tests
add 68ce11e67e fix UX issues/bugs
add 3909037d95 converting class->functional components so they can use useTheme()
add 90953ed1b2 Update .gitignore
add f7bd405aac Update superset-frontend/src/components/ListView/Filters/Search.tsx
add 7954638d8b fix urls / refresh page when on
add bec354d9d4 removed priority 2
add e30a589b91 remove uuid complexity from config
add 9b11ed0c25 tackling
add b9d3858e42 fix bolts
add f4fbb30445 import functionality
add 9091b2cb22 UX tweaks, verbage
add 8e9d348eca Kill redundant feature flag
add 7a5824400c eslint
add a195b9076f pylint
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (deb00c9b51)
\
N -- N -- N refs/heads/theme_crud (a195b9076f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.pre-commit-config.yaml | 13 +-
UPDATING.md | 1 +
docs/yarn.lock | 10 +-
pyproject.toml | 16 +-
scripts/check-type.js | 101 ++++++--
.../cypress/e2e/dashboard/drillby.test.ts | 6 +-
.../e2e/dashboard/horizontalFilterBar.test.ts | 1 +
superset-frontend/package-lock.json | 9 +-
superset-frontend/package.json | 3 +-
.../src/components/ControlHeader.tsx | 17 +-
.../src/components/Select.tsx | 4 +-
.../src/components/Button/index.tsx | 4 +-
.../components/Collapse/CollapseLabelInModal.tsx | 58 ++---
.../src/components/ConfirmStatusChange/index.tsx | 1 +
.../src/components/DeleteModal/index.tsx | 2 +
.../src/components/DeleteModal/types.ts | 1 +
.../src/components/EmptyState/index.tsx | 4 +-
.../src/components/EmptyState/types.ts | 2 +
.../src/components/LastUpdated/index.tsx | 21 +-
.../src/components/Modal/FormModal.tsx | 2 +
.../src/components/Modal/Modal.tsx | 6 +-
.../src/components/ModalTrigger/index.tsx | 1 +
.../src/components/Typography/index.tsx | 1 +
.../src/components/UnsavedChangesModal/index.tsx | 159 +++++-------
.../superset-ui-core/src/components/index.ts | 1 +
.../superset-ui-core/src/connection/constants.ts | 2 +-
.../src/layers/Hex/controlPanel.ts | 6 +-
.../src/utilities/utils.ts | 2 +-
.../src/AgGridTable/index.tsx | 75 +++++-
.../plugin-chart-ag-grid-table/src/consts.ts | 4 -
.../plugins/plugin-chart-ag-grid-table/src/i18n.ts | 66 -----
.../plugins/plugin-chart-table/src/consts.ts | 5 +-
.../plugins/plugin-chart-table/src/i18n.ts | 66 -----
.../SqlLab/components/SaveDatasetModal/index.tsx | 24 +-
.../src/SqlLab/components/SaveQuery/index.tsx | 12 +-
.../src/SqlLab/components/SqlEditor/index.tsx | 1 +
.../src/SqlLab/components/TableElement/index.tsx | 4 +-
.../assets/images/icons/big_number_chart_tile.svg | Bin 1321 -> 1380 bytes
.../src/components/Chart/DrillBy/DrillByModal.tsx | 1 +
.../Chart/DrillDetail/DrillDetailModal.tsx | 1 +
.../components/Chart/MenuItemWithTruncation.tsx | 2 +-
.../src/components/Chart/chartAction.js | 6 +-
.../Datasource/ChangeDatasourceModal.tsx | 1 +
.../src/components/Datasource/DatasourceEditor.jsx | 65 ++---
.../src/components/ErrorMessage/ErrorAlert.tsx | 1 +
.../src/components/ImportModal/index.tsx | 3 +-
.../src/components/MessageToasts/Toast.tsx | 1 -
.../ModalTitleWithIcon/ModalTitleWithIcon.test.tsx | 60 +++++
.../src/components/ModalTitleWithIcon/index.tsx | 62 +++++
.../dashboard/components/EmbeddedModal/index.tsx | 9 +-
.../PropertiesModal/PropertiesModal.test.tsx | 4 +-
.../dashboard/components/PropertiesModal/index.tsx | 5 +-
.../src/dashboard/components/SaveModal.tsx | 5 +-
.../CrossFilters/ScopingModal/ScopingModal.tsx | 4 +-
superset-frontend/src/dashboard/styles.ts | 14 +-
.../src/explore/components/ControlHeader.tsx | 1 +
.../explore/components/ControlPanelsContainer.tsx | 1 +
.../src/explore/components/EmbedCodeContent.jsx | 2 +-
.../explore/components/PropertiesModal/index.tsx | 20 +-
.../ColorBreakpointPopoverControl.tsx | 2 +-
.../controls/DateFilterControl/DateFilterLabel.tsx | 23 +-
.../DndColumnSelectControl/ColumnSelectPopover.tsx | 7 +-
.../explore/components/controls/ViewQuery.test.tsx | 38 ++-
.../src/explore/components/controls/ViewQuery.tsx | 10 +-
.../controls/VizTypeControl/constants.tsx | 2 +-
.../src/features/alerts/AlertReportModal.tsx | 20 +-
.../annotationLayers/AnnotationLayerModal.tsx | 41 ++--
.../src/features/annotations/AnnotationModal.tsx | 29 +--
.../src/features/cssTemplates/CssTemplateModal.tsx | 37 +--
.../src/features/databases/DatabaseModal/index.tsx | 53 ++--
.../features/databases/UploadDataModel/index.tsx | 14 +-
.../features/datasets/DuplicateDatasetModal.tsx | 11 +-
.../src/features/groups/GroupListModal.tsx | 9 +-
superset-frontend/src/features/home/ChartTable.tsx | 18 +-
.../src/features/home/DashboardTable.tsx | 17 +-
.../src/features/home/SavedQueries.tsx | 5 +-
.../src/features/rls/RowLevelSecurityModal.tsx | 28 +--
.../src/features/roles/RoleListAddModal.tsx | 12 +-
.../src/features/roles/RoleListDuplicateModal.tsx | 11 +-
.../src/features/roles/RoleListEditModal.tsx | 10 +-
.../src/features/tags/BulkTagModal.tsx | 4 +-
superset-frontend/src/features/tags/TagModal.tsx | 10 +-
.../src/features/themes/ThemeModal.tsx | 254 ++++++++++---------
.../src/features/users/UserListModal.tsx | 9 +-
.../src/pages/AlertReportList/index.tsx | 36 ++-
.../src/pages/AnnotationLayerList/index.tsx | 32 +--
.../src/pages/AnnotationList/index.tsx | 8 +-
superset-frontend/src/pages/ChartList/index.tsx | 43 ++--
.../src/pages/CssTemplateList/index.tsx | 18 +-
.../src/pages/DashboardList/index.tsx | 43 ++--
superset-frontend/src/pages/DatabaseList/index.tsx | 16 +-
superset-frontend/src/pages/DatasetList/index.tsx | 40 ++-
superset-frontend/src/pages/GroupsList/index.tsx | 33 +--
superset-frontend/src/pages/Home/index.tsx | 1 +
superset-frontend/src/pages/RolesList/index.tsx | 8 +-
.../src/pages/RowLevelSecurityList/index.tsx | 26 +-
.../src/pages/SavedQueryList/index.tsx | 40 ++-
superset-frontend/src/pages/Tags/index.tsx | 15 +-
superset-frontend/src/pages/UserInfo/index.tsx | 1 -
superset-frontend/src/pages/UsersList/index.tsx | 8 +-
superset-frontend/src/setup/setupClient.ts | 32 +++
superset-frontend/src/utils/downloadAsImage.ts | 273 ++++++++++++++++++---
superset/app.py | 21 +-
superset/commands/dataset/create.py | 11 +-
superset/commands/sql_lab/export.py | 4 +-
superset/config.py | 13 +-
superset/connectors/sqla/utils.py | 8 +-
superset/db_engine_specs/__init__.py | 2 +-
superset/examples/bart_lines.py | 2 +-
superset/examples/birth_names.py | 2 +-
superset/examples/multiformat_time_series.py | 2 +-
superset/examples/supported_charts_dashboard.py | 2 +-
superset/extensions/pylint.py | 37 ---
.../shared/migrate_viz/query_functions.py | 2 +-
...2_convert_metric_currencies_from_str_to_json.py | 2 +-
superset/models/sql_lab.py | 4 +-
superset/sql/parse.py | 42 ++--
superset/utils/core.py | 110 ++++++++-
superset/views/base.py | 6 +
tests/integration_tests/datasets/api_tests.py | 30 +++
.../db_engine_specs/base_engine_spec_tests.py | 6 +-
.../fixtures/dashboard_with_tabs.py | 2 +-
tests/integration_tests/sql_lab/api_tests.py | 31 ++-
tests/integration_tests/sql_lab/commands_tests.py | 8 +-
.../sql_lab/permalink/api_tests.py | 2 +-
.../databases/importers/v1/command_test.py | 2 +-
tests/unit_tests/commands/dataset/test_create.py | 170 +++++++++++++
tests/unit_tests/commands/report/execute_test.py | 2 +-
.../common/test_query_context_processor.py | 8 +-
tests/unit_tests/connectors/sqla/test_utils.py | 123 ++++++++++
tests/unit_tests/db_engine_specs/test_base.py | 2 +-
.../unit_tests/migrations/shared/catalogs_test.py | 2 +-
tests/unit_tests/models/sql_lab_test.py | 45 +++-
tests/unit_tests/security/manager_test.py | 2 +-
tests/unit_tests/sql_lab_test.py | 2 +-
tests/unit_tests/utils/map_type_tests.py | 86 +++++++
136 files changed, 2029 insertions(+), 1090 deletions(-)
delete mode 100644 superset-frontend/plugins/plugin-chart-ag-grid-table/src/i18n.ts
delete mode 100644 superset-frontend/plugins/plugin-chart-table/src/i18n.ts
create mode 100644 superset-frontend/src/components/ModalTitleWithIcon/ModalTitleWithIcon.test.tsx
create mode 100644 superset-frontend/src/components/ModalTitleWithIcon/index.tsx
create mode 100644 tests/unit_tests/commands/dataset/test_create.py
create mode 100644 tests/unit_tests/connectors/sqla/test_utils.py
create mode 100644 tests/unit_tests/utils/map_type_tests.py