You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/04 18:52:30 UTC

[GitHub] [tvm] mbrookhart opened a new pull request #7035: Implement Keras Conv1D

mbrookhart opened a new pull request #7035:
URL: https://github.com/apache/tvm/pull/7035


   @jwfromm @jroesch @masahi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on a change in pull request #7035: Implement Keras Conv1D

Posted by GitBox <gi...@apache.org>.
jwfromm commented on a change in pull request #7035:
URL: https://github.com/apache/tvm/pull/7035#discussion_r536316345



##########
File path: python/tvm/relay/frontend/keras.py
##########
@@ -1102,7 +1178,12 @@ def _convert_input_layer(keras_layer):
 
     etab = ExprTable()
     # Set global data format.
-    assert layout in ["NCHW", "NHWC", "NDHWC"], "Layout must be one of 'NCHW', NHWC or NDHWC"
+    assert layout in [
+        "NWC",
+        "NCHW",
+        "NHWC",
+        "NDHWC",
+    ], "Layout must be one of 'NWC', 'NCHW', NHWC or NDHWC"

Review comment:
       looking at this made me realize we should just have 'channels_first' and 'channels_last' as layout options so that it applies to all dimensions. No change needed for this PR but we should keep it in mind as a backlog item to fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #7035: Implement Keras Conv1D

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7035:
URL: https://github.com/apache/tvm/pull/7035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7035: Implement Keras Conv1D

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7035:
URL: https://github.com/apache/tvm/pull/7035#issuecomment-739082534


   Thanks @mbrookhart @jwfromm 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org