You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/02 06:50:20 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1173: Implement more multiple bytes string functions required by libc++

xiaoxiang781216 opened a new pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173


   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1173: Implement more multiple bytes string functions required by libc++

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433687628



##########
File path: include/limits.h
##########
@@ -68,6 +70,13 @@
 #  endif
 #endif
 
+/* Maximum length of any multibyte character in any locale.
+ * We define this value here since the gcc header does not define
+ * the correct value.
+ */
+
+#define MB_LEN_MAX            8

Review comment:
       Copy from lib_wctob.c it is fine to change to 1 since nuttx doesn't really support utf8 or other multiple bytes encoding. Do you prefer one?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1173: Implement more multiple bytes string functions required by libc++

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1173: Implement more multiple bytes string functions required by libc++

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433765238



##########
File path: include/limits.h
##########
@@ -68,6 +70,13 @@
 #  endif
 #endif
 
+/* Maximum length of any multibyte character in any locale.
+ * We define this value here since the gcc header does not define
+ * the correct value.
+ */
+
+#define MB_LEN_MAX            8

Review comment:
       Ok, I change to 1 base on the current implementation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #1173: Implement more multiple bytes string functions required by libc++

Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433742318



##########
File path: include/limits.h
##########
@@ -68,6 +70,13 @@
 #  endif
 #endif
 
+/* Maximum length of any multibyte character in any locale.
+ * We define this value here since the gcc header does not define
+ * the correct value.
+ */
+
+#define MB_LEN_MAX            8

Review comment:
       @xiaoxiang781216 
   
   MB_LEN_MAX | Maximum number of bytes in a multibyte character, for any locale | 1 or greater*
   * the actual value depends on the particular system and library implementation, but shall reflect the limits of these types in the target platform.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1173: Implement more multiple bytes string functions required by libc++

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-nuttx/pull/1173#discussion_r433683505



##########
File path: include/limits.h
##########
@@ -68,6 +70,13 @@
 #  endif
 #endif
 
+/* Maximum length of any multibyte character in any locale.
+ * We define this value here since the gcc header does not define
+ * the correct value.
+ */
+
+#define MB_LEN_MAX            8

Review comment:
       why 8, not 1?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org