You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/10/05 22:53:08 UTC

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2081#issuecomment-334613994
 
 
   I reviewed this code with regards to CloudPlatform 4.11. It LGTM there with the exception of one feature it broke (when locationtype=secondary on createSnapshot). I provided the necessary fix to Accelerite.
   
   I can run the managed-storage regression test suite on this code (CloudStack 4.10) and post results. If it passes those tests, then I am good with this PR going in.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services