You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/13 07:48:27 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1072: HDDS-3796. Allow running coverage locally
adoroszlai opened a new pull request #1072:
URL: https://github.com/apache/hadoop-ozone/pull/1072
## What changes were proposed in this pull request?
`coverage-report.sh` is currently GitHub-specific, but can be fixed to work locally by a minor change in where it looks for `jacoco-combined.exec` files.
Also rename to `coverage.sh` and relocate to the common `checks` directory, since it's no longer GitHub-specific.
https://issues.apache.org/jira/browse/HDDS-3796
## How was this patch tested?
Verified that `coverage.sh` works fine locally after a complete build and running some tests:
```
mvn -Dskip.npx -Dskip.installnpx -DskipShade clean package
hadoop-ozone/dev-support/checks/unit.sh -DfailIfNoTests=false -Dtest='TestConfigFileAppender,TestOzoneConfiguration'
hadoop-ozone/dev-support/checks/coverage.sh
open target/coverage/all/org.apache.hadoop.hdds.conf/index.html
```
Verified that coverage check is OK in post-commit:
https://github.com/adoroszlai/hadoop-ozone/runs/767705840
and that it uploaded data to codecov.io:
https://codecov.io/gh/adoroszlai/hadoop-ozone/branch/HDDS-3796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #1072: HDDS-3796. Allow running coverage locally
Posted by GitBox <gi...@apache.org>.
dineshchitlangia merged pull request #1072:
URL: https://github.com/apache/hadoop-ozone/pull/1072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1072: HDDS-3796. Allow running coverage locally
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1072:
URL: https://github.com/apache/hadoop-ozone/pull/1072#issuecomment-643630301
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=h1) Report
> Merging [#1072](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/96f07d5c27ba8f2ab9d77df25e10d4cb94489e5f&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1072 +/- ##
============================================
+ Coverage 69.36% 69.44% +0.08%
- Complexity 9103 9111 +8
============================================
Files 961 961
Lines 48127 48127
Branches 4676 4676
============================================
+ Hits 33381 33422 +41
+ Misses 12530 12491 -39
+ Partials 2216 2214 -2
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...otocol/commands/RetriableDatanodeEventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sL2NvbW1hbmRzL1JldHJpYWJsZURhdGFub2RlRXZlbnRXYXRjaGVyLmphdmE=) | `55.55% <0.00%> (-44.45%)` | `3.00% <0.00%> (-1.00%)` | |
| [...er/common/transport/server/GrpcXceiverService.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvR3JwY1hjZWl2ZXJTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (ø%)` | |
| [...ine/commandhandler/DeleteBlocksCommandHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9jb21tYW5kaGFuZGxlci9EZWxldGVCbG9ja3NDb21tYW5kSGFuZGxlci5qYXZh) | `62.50% <0.00%> (-1.57%)` | `9.00% <0.00%> (-2.00%)` | |
| [.../apache/hadoop/ozone/client/io/KeyInputStream.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL2NsaWVudC9pby9LZXlJbnB1dFN0cmVhbS5qYXZh) | `78.19% <0.00%> (-1.51%)` | `42.00% <0.00%> (-1.00%)` | |
| [.../common/states/endpoint/HeartbeatEndpointTask.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlcy9lbmRwb2ludC9IZWFydGJlYXRFbmRwb2ludFRhc2suamF2YQ==) | `69.81% <0.00%> (-1.26%)` | `25.00% <0.00%> (-1.00%)` | |
| [.../ozone/container/common/volume/AbstractFuture.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3ZvbHVtZS9BYnN0cmFjdEZ1dHVyZS5qYXZh) | `30.12% <0.00%> (-0.52%)` | `20.00% <0.00%> (-1.00%)` | |
| [.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PbU1ldGFkYXRhTWFuYWdlckltcGwuamF2YQ==) | `82.25% <0.00%> (-0.27%)` | `91.00% <0.00%> (-1.00%)` | |
| [...hadoop/ozone/om/ratis/OzoneManagerRatisServer.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9Pem9uZU1hbmFnZXJSYXRpc1NlcnZlci5qYXZh) | `80.07% <0.00%> (+0.78%)` | `36.00% <0.00%> (+1.00%)` | |
| [...doop/ozone/container/keyvalue/KeyValueHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIva2V5dmFsdWUvS2V5VmFsdWVIYW5kbGVyLmphdmE=) | `62.00% <0.00%> (+1.11%)` | `64.00% <0.00%> (+2.00%)` | |
| [...mon/transport/server/ratis/XceiverServerRatis.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvWGNlaXZlclNlcnZlclJhdGlzLmphdmE=) | `92.60% <0.00%> (+2.36%)` | `57.00% <0.00%> (+3.00%)` | |
| ... and [5 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=footer). Last update [96f07d5...bf5b81e](https://codecov.io/gh/apache/hadoop-ozone/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1072: HDDS-3796. Allow running coverage locally
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1072:
URL: https://github.com/apache/hadoop-ozone/pull/1072#issuecomment-645755817
Thanks @vivekratnavel for the review, and @dineshchitlangia for reviewing and committing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org