You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/04/27 12:54:24 UTC

[GitHub] [spark] srowen commented on a diff in pull request #40933: [SPARK-43263][BUILD] Upgrade `FasterXML jackson` to 2.15.0

srowen commented on code in PR #40933:
URL: https://github.com/apache/spark/pull/40933#discussion_r1179112142


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala:
##########
@@ -43,6 +43,21 @@ private[sql] class JSONOptions(
 
   import JSONOptions._
 
+  private val maxNestingDepth: Int = parameters

Review Comment:
   I think this is fine. It's a niche set of configs that very few would set. If they set a bad value, a raw error is even OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org