You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/09 07:12:54 UTC

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #18250: [Issue#18169] add unit test for DatabaseTypeEngine

terrymanu commented on code in PR #18250:
URL: https://github.com/apache/shardingsphere/pull/18250#discussion_r893148799


##########
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeEngineTest.java:
##########
@@ -140,6 +149,9 @@ private DataSource mockDataSource(final DatabaseType databaseType) throws SQLExc
             case "SQLServer":
                 url = "jdbc:microsoft:sqlserver://127.0.0.1;DatabaseName=test";
                 break;
+            case "FIXTURE":
+                url = "jdbc:fixture://localhost;DatabaseName=test";
+                break;

Review Comment:
   Why add "FIXTURE" here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org