You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/27 02:11:29 UTC
Review Request 70316: Updated test `ImportPreprovisionedVolume` for
better code coverage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9655
https://issues.apache.org/jira/browse/MESOS-9655
Repository: mesos
Description
-------
This patch renames `ImportPreprovisionedVolume` to
`ImportDestroyPreprovisionedVolume` add tests two additional scenarios:
* `CREATE_DISK` with an unknown profile.
* `DESTROY_DISK` with a `RAW` disk.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70316/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70316: Updated test `ImportPreprovisionedVolume`
for better code coverage.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/#review214081
-----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp
Line 2962 (original), 2984 (patched)
<https://reviews.apache.org/r/70316/#comment300252>
```
../src/tests/storage_local_resource_provider_tests.cpp:2982: Failure
Mock function called more times than expected - returning directly.
Function call: resourceOffers(0x7ffe5a8d5fd8, @0x7efc7b1b0510 { 160-byte object <50-A5 AE-85 FC-7E 00-00 00-00 00-00 00-00 00-00 5F-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 06-00 00-00 06-00 00-00 A0-25 01-48 FC-7E 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 ... 10-13 00-48 FC-7E 00-00 40-13 00-48 FC-7E 00-00 D0-13 00-48 FC-7E 00-00 70-14 00-48 FC-7E 00-00 C0-32 00-48 FC-7E 00-00 00-00 00-00 00-00 00-00 20-34 00-48 FC-7E 00-00 00-00 00-00 00-00 00-00> })
Expected: to be called once
Actual: called twice - over-saturated and active
```
- Chun-Hung Hsiao
On March 27, 2019, 3:45 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70316/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 3:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9540
> https://issues.apache.org/jira/browse/MESOS-9540
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames `ImportPreprovisionedVolume` to
> `CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
>
> * `CREATE_DISK` with an unknown profile.
>
> * `DESTROY_DISK` with a `RAW` disk.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70316/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70316: Updated test `ImportPreprovisionedVolume`
for better code coverage.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/#review214078
-----------------------------------------------------------
PASS: Mesos patch 70316 was successfully built and tested.
Reviews applied: `['70313', '70314', '70315', '70316']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3021/mesos-review-70316
- Mesos Reviewbot Windows
On March 27, 2019, 3:45 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70316/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 3:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9540
> https://issues.apache.org/jira/browse/MESOS-9540
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames `ImportPreprovisionedVolume` to
> `CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
>
> * `CREATE_DISK` with an unknown profile.
>
> * `DESTROY_DISK` with a `RAW` disk.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70316/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70316: Updated test `ImportPreprovisionedVolume`
for better code coverage.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On March 27, 2019, 11 a.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 2931 (patched)
> > <https://reviews.apache.org/r/70316/diff/2/?file=2134400#file2134400line2931>
> >
> > Is this related to above comment block?
Yes, "the extra storage pool."
> On March 27, 2019, 11 a.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3050 (patched)
> > <https://reviews.apache.org/r/70316/diff/2/?file=2134400#file2134400line3071>
> >
> > Let's add an assertion that the range resulting from the filter is actually non-empty.
The "AllOf" expectation matcher should have ensured that.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/#review214094
-----------------------------------------------------------
On March 27, 2019, 3:45 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70316/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 3:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9540
> https://issues.apache.org/jira/browse/MESOS-9540
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames `ImportPreprovisionedVolume` to
> `CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
>
> * `CREATE_DISK` with an unknown profile.
>
> * `DESTROY_DISK` with a `RAW` disk.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70316/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70316: Updated test `ImportPreprovisionedVolume`
for better code coverage.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/#review214094
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/storage_local_resource_provider_tests.cpp
Lines 2922-2923 (patched)
<https://reviews.apache.org/r/70316/#comment300263>
`s/reregistration/registration/`?
src/tests/storage_local_resource_provider_tests.cpp
Lines 2931 (patched)
<https://reviews.apache.org/r/70316/#comment300264>
Is this related to above comment block?
src/tests/storage_local_resource_provider_tests.cpp
Lines 3028 (patched)
<https://reviews.apache.org/r/70316/#comment300265>
Add a comment here documenting what triggered this allocation.
src/tests/storage_local_resource_provider_tests.cpp
Lines 3050 (patched)
<https://reviews.apache.org/r/70316/#comment300266>
Let's add an assertion that the range resulting from the filter is actually non-empty.
src/tests/storage_local_resource_provider_tests.cpp
Line 3007 (original), 3054 (patched)
<https://reviews.apache.org/r/70316/#comment300267>
Ditto.
src/tests/storage_local_resource_provider_tests.cpp
Line 3008 (original), 3071 (patched)
<https://reviews.apache.org/r/70316/#comment300268>
Document what triggered the allocation.
- Benjamin Bannier
On March 27, 2019, 4:45 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70316/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 4:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9540
> https://issues.apache.org/jira/browse/MESOS-9540
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames `ImportPreprovisionedVolume` to
> `CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
>
> * `CREATE_DISK` with an unknown profile.
>
> * `DESTROY_DISK` with a `RAW` disk.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70316/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70316: Updated test `ImportPreprovisionedVolume`
for better code coverage.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/
-----------------------------------------------------------
(Updated March 28, 2019, 5:15 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comments and fixed a flake.
Bugs: MESOS-9540
https://issues.apache.org/jira/browse/MESOS-9540
Repository: mesos
Description
-------
This patch renames `ImportPreprovisionedVolume` to
`CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
* `CREATE_DISK` with an unknown profile.
* `DESTROY_DISK` with a `RAW` disk.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
Diff: https://reviews.apache.org/r/70316/diff/3/
Changes: https://reviews.apache.org/r/70316/diff/2-3/
Testing (updated)
-------
make check
Ran 1000 times.
Thanks,
Chun-Hung Hsiao
Re: Review Request 70316: Updated test `ImportPreprovisionedVolume`
for better code coverage.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/
-----------------------------------------------------------
(Updated March 27, 2019, 3:45 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Made the name more consistent with other tests.
Bugs: MESOS-9540
https://issues.apache.org/jira/browse/MESOS-9540
Repository: mesos
Description (updated)
-------
This patch renames `ImportPreprovisionedVolume` to
`CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
* `CREATE_DISK` with an unknown profile.
* `DESTROY_DISK` with a `RAW` disk.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
Diff: https://reviews.apache.org/r/70316/diff/2/
Changes: https://reviews.apache.org/r/70316/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao