You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/22 21:17:45 UTC

[GitHub] dgrove-oss edited a comment on issue #428: Missing liveness and readiness probes in all components

dgrove-oss edited a comment on issue #428: Missing liveness and readiness probes in all components
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/428#issuecomment-466550912
 
 
   Agreed, but it is not always clear how to define a valid readiness probe. 
   
   I added them for zookeeper in #430.
   
   There is some logic in https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/helm/openwhisk/templates/_readiness.tpl that may be able to be adapted for a few other cases.
   
   I  would love to find out a valid way to probe kafka for readiness (vs. liveness) externally so we could get rid of the kludge here: https://github.com/apache/incubator-openwhisk-deploy-kube/blob/115debb691ad228dccc9c0a9e6c32736f3319268/helm/openwhisk/templates/_readiness.tpl#L24-L25

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services