You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/30 01:39:31 UTC

Review Request 17519: Added a missing lock acquisition in /__processes__.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17519/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-954
    https://issues.apache.org/jira/browse/MESOS-954


Repository: mesos-git


Description
-------

The process lock must be acquired before examining the event queue!


Diffs
-----

  3rdparty/libprocess/src/process.cpp c28fc35e2fc2e5416691f52f2209e894d72e1c20 

Diff: https://reviews.apache.org/r/17519/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request 17519: Added a missing lock acquisition in /__processes__.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17519/#review33188
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/17519/#comment62527>

    Can we wrap the body in another block?
    
    process->lock();
    {
      foreach (Event* event, process->events) {
        ...;
      }
    }
    process->unlock();


- Benjamin Hindman


On Jan. 30, 2014, 12:39 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17519/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 12:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-954
>     https://issues.apache.org/jira/browse/MESOS-954
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The process lock must be acquired before examining the event queue!
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp c28fc35e2fc2e5416691f52f2209e894d72e1c20 
> 
> Diff: https://reviews.apache.org/r/17519/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 17519: Added a missing lock acquisition in /__processes__.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17519/
-----------------------------------------------------------

(Updated Jan. 30, 2014, 1:10 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Benh review.


Bugs: MESOS-954
    https://issues.apache.org/jira/browse/MESOS-954


Repository: mesos-git


Description
-------

The process lock must be acquired before examining the event queue!


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp c28fc35e2fc2e5416691f52f2209e894d72e1c20 

Diff: https://reviews.apache.org/r/17519/diff/


Testing
-------

make check


Thanks,

Ben Mahler