You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2012/01/09 04:25:41 UTC
[jira] [Created] (MAPREDUCE-3642) Remove hardcoded strings from the
JC#displayTasks() call.
Remove hardcoded strings from the JC#displayTasks() call.
---------------------------------------------------------
Key: MAPREDUCE-3642
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: client
Affects Versions: 0.24.0
Reporter: Harsh J
Assignee: Harsh J
This is to address Eli's comments on the parent task:
bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3642) Remove hardcoded strings from the
JC#displayTasks() call.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3642:
-------------------------------
Fix Version/s: (was: 0.24.0)
> Remove hardcoded strings from the JC#displayTasks() call.
> ---------------------------------------------------------
>
> Key: MAPREDUCE-3642
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to address Eli's comments on the parent task:
> bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
> bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3642) Remove hardcoded strings from the
JC#displayTasks() call.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3642:
-------------------------------
Target Version/s: 2.0.1-alpha (was: 0.24.0)
Affects Version/s: (was: 0.24.0)
2.0.0-alpha
> Remove hardcoded strings from the JC#displayTasks() call.
> ---------------------------------------------------------
>
> Key: MAPREDUCE-3642
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Labels: newbie
> Attachments: MR-3642.1.patch
>
>
> This is to address Eli's comments on the parent task:
> bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
> bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-3642) Remove hardcoded strings from
the JC#displayTasks() call.
Posted by "Harsh J (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned MAPREDUCE-3642:
----------------------------------
Assignee: (was: Harsh J)
> Remove hardcoded strings from the JC#displayTasks() call.
> ---------------------------------------------------------
>
> Key: MAPREDUCE-3642
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Labels: newbie
>
> This is to address Eli's comments on the parent task:
> bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
> bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3642) Remove hardcoded strings from the
JC#displayTasks() call.
Posted by "OZAWA Tsuyoshi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
OZAWA Tsuyoshi updated MAPREDUCE-3642:
--------------------------------------
Attachment: MR-3642.1.patch
The attached patch fixes the problems noted above.
> Remove hardcoded strings from the JC#displayTasks() call.
> ---------------------------------------------------------
>
> Key: MAPREDUCE-3642
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Labels: newbie
> Attachments: MR-3642.1.patch
>
>
> This is to address Eli's comments on the parent task:
> bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
> bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3642) Remove hardcoded strings from
the JC#displayTasks() call.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404569#comment-13404569 ]
Harsh J commented on MAPREDUCE-3642:
------------------------------------
Hey MR JIRA Admins,
Please assign contributor rights to Tsuyoshi OZAWA on JIRA. User profile https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ozawa.
I lack the permissions to do so. Thanks!
> Remove hardcoded strings from the JC#displayTasks() call.
> ---------------------------------------------------------
>
> Key: MAPREDUCE-3642
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Labels: newbie
> Attachments: MR-3642.1.patch
>
>
> This is to address Eli's comments on the parent task:
> bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
> bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3642) Remove hardcoded strings from
the JC#displayTasks() call.
Posted by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397935#comment-13397935 ]
Tsuyoshi OZAWA commented on MAPREDUCE-3642:
-------------------------------------------
Harsh,
I'd like to deal with this ticket, however, I don't have a contributor privilege.
Could you give it to me?
> Remove hardcoded strings from the JC#displayTasks() call.
> ---------------------------------------------------------
>
> Key: MAPREDUCE-3642
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3642
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Labels: newbie
> Attachments: MR-3642.1.patch
>
>
> This is to address Eli's comments on the parent task:
> bq. 1. The error messages should generate the lists of valid states and types from their definitions rather than hard-coding them into the error messages.
> bq. 2. Aren't these types and states defined somewhere already? Seems like they're a public API and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira