You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Felix Schumacher <fe...@internetallee.de> on 2019/07/18 10:42:24 UTC
Review of PR 475 cURL additions
Hi all,
one really minor question on naming :)
How do we want to spell mixed abbreviations with normal word in methods,
variables and constants (especially lower/uppercase)?
a) getDNSResolver, dnsResolver, DNS_RESOLVER
b) getDnsResolver, dnsResolver, DNS_RESOLVER
c) getDNSResolver, dNSResolver, DNS_RESOLVER
I tend to prefer variant a).
As DNS is an abbreviation of three words that should be written using
the same case -- either upper- or lowercase.
What is your take on this?
Felix
Re: Review of PR 475 cURL additions
Posted by Philippe Mouawad <ph...@gmail.com>.
On Thursday, July 18, 2019, Vladimir Sitnikov <si...@gmail.com>
wrote:
> b) is the best: getDnsResolver, dnsResolver, DNS_RESOLVER
the best per your opinion :)
>
> The nice thing for getDnsResolver is you never have to guess the right
> casing.
> We have lots of "Http..." in class names. It would really look weird to
> have HTTP.
> It is simpler to convert between "field name" and "getter name" as well.
> You just alter the first letter.
but you get the point with this
>
> So, friends, never let friends to use getDNSResolver :)
ok
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: Review of PR 475 cURL additions
Posted by Philippe Mouawad <ph...@gmail.com>.
On Thu, Jul 18, 2019 at 2:54 PM Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
>
> Am 18.07.19 um 13:05 schrieb Vladimir Sitnikov:
> > b) is the best: getDnsResolver, dnsResolver, DNS_RESOLVER
> >
> > The nice thing for getDnsResolver is you never have to guess the right
> > casing.
> > We have lots of "Http..." in class names. It would really look weird to
> > have HTTP.
> > It is simpler to convert between "field name" and "getter name" as well.
> > You just alter the first letter.
> >
> > So, friends, never let friends to use getDNSResolver :)
>
> So it is at the moment two for a) and one for b), but you have a good
> point on your site as to be consistent with historic commits.
>
> So I am OK with b).
>
> @Philippe, are you OK with it, too?
>
Yes
>
> Felix
>
> >
> > Vladimir
> >
>
--
Cordialement.
Philippe Mouawad.
Re: Review of PR 475 cURL additions
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 18.07.19 um 13:05 schrieb Vladimir Sitnikov:
> b) is the best: getDnsResolver, dnsResolver, DNS_RESOLVER
>
> The nice thing for getDnsResolver is you never have to guess the right
> casing.
> We have lots of "Http..." in class names. It would really look weird to
> have HTTP.
> It is simpler to convert between "field name" and "getter name" as well.
> You just alter the first letter.
>
> So, friends, never let friends to use getDNSResolver :)
So it is at the moment two for a) and one for b), but you have a good
point on your site as to be consistent with historic commits.
So I am OK with b).
@Philippe, are you OK with it, too?
Felix
>
> Vladimir
>
Re: Review of PR 475 cURL additions
Posted by Vladimir Sitnikov <si...@gmail.com>.
b) is the best: getDnsResolver, dnsResolver, DNS_RESOLVER
The nice thing for getDnsResolver is you never have to guess the right
casing.
We have lots of "Http..." in class names. It would really look weird to
have HTTP.
It is simpler to convert between "field name" and "getter name" as well.
You just alter the first letter.
So, friends, never let friends to use getDNSResolver :)
Vladimir
Re: Review of PR 475 cURL additions
Posted by Philippe Mouawad <ph...@gmail.com>.
a) as of me
On Thursday, July 18, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Hi all,
>
> one really minor question on naming :)
>
> How do we want to spell mixed abbreviations with normal word in methods,
> variables and constants (especially lower/uppercase)?
>
> a) getDNSResolver, dnsResolver, DNS_RESOLVER
>
> b) getDnsResolver, dnsResolver, DNS_RESOLVER
>
> c) getDNSResolver, dNSResolver, DNS_RESOLVER
>
> I tend to prefer variant a).
>
> As DNS is an abbreviation of three words that should be written using
> the same case -- either upper- or lowercase.
>
> What is your take on this?
>
> Felix
>
>
--
Cordialement.
Philippe Mouawad.