[jira] [Commented] (TS-1671) It seems that AlarmListable in overviewRecord is obsolete

["Zhao Yongming (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569480#comment-13569480 ] 

Zhao Yongming commented on TS-1671:
-----------------------------------

looks like this another broken web2 feature, from the codes you deleted, we can assume there is an feature in the webui, that may display the cluster members with some status for example up/down and alarms, you can identify the alarm as known or new coming.

sounds a cool advanced feature to me. maybe we should implement this in some less complicated way, ie, using some api to query the status from the cluster members and script tools do the rest.

web2 is a hell that none is interesting in manage it, we should do as much cleanup as possible.

+1 for your patch
                
> It seems that AlarmListable in overviewRecord is obsolete
> ---------------------------------------------------------
>
>                 Key: TS-1671
>                 URL: https://issues.apache.org/jira/browse/TS-1671
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cleanup, Management
>            Reporter: Yunkai Zhang
>         Attachments: 0001-TS-1671-Remove-useless-AlarmListable-and-related-fun.patch
>
>
> Yunkai Zhang <yu...@gmail.com>
> Jan 25 (5 days ago)
> to dev-trafficser. 
> Hi folks:
> What is the purpose of AlarmListTable in overviewRecord?  Does it outdate?
> It seems that, in the following steps:
> 1. Objects of AlarmListTable is added into overviewRecord::nodeAlarms and overviewRecord::notFoundAlarms lists by overviewAlarmCallback()/addAlarm()
> 2. And then, they are removed by checkAlarms()/addSelfRecord()
> AlarmListTable does nothing at all.
> If it's obsolete, I'm going to clean it.
> James Peach <jp...@apache.org>
> 1:47 PM (56 minutes ago)
> It looks like dead code to me. I'm going to guess it was once used for the Inktomi cache appliance? I would not be sorry to see all the web management removed ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira