You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/20 16:12:29 UTC
[GitHub] [spark] akiyamaneko opened a new pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
akiyamaneko opened a new pull request #30446:
URL: https://github.com/apache/spark/pull/30446
### What changes were proposed in this pull request?
To make sure the sensitive attributes to be redacted in the history server log.
### Why are the changes needed?
There are many event types in spark application, such as *SparkListenerEnvironmentUpdate*, *SparkListenerJobStart*, *SparkListenerStageSubmitted *etc.
sensitive attributes in `SparkListenerEnvironmentUpdate` looks well like '********(redacted)'
but these attributes in SparkListenerJobStart and SparkListenerStageSubmitted events would not been redated, resulting in sensitive attributes be viewd directly.
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ut
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731598521
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36080/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731601675
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36080/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731582375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731721233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731400801
Redaction support looks kind of inconsistent.
For `ApplicationEnvironmentInfo`, the event file contains unredacted event with the api redacting on demand.
On other hand, `SparkListenerEnvironmentUpdate` is redacted before getting logged into event file.
The current pr takes the approach of `SparkListenerEnvironmentUpdate` - and logs redacted events.
Personally I am inclined to have source of truth in the event file, and expose redacted view.
But then, all of these was last changed 4 years or so back (#15971).
Any thoughts @vanzin, @tgravescs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731774750
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731728690
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-733832829
@tgravescs The question I had was regarding when redaction is applied - while logging the event or when surfacing in UI/cli/etc.
Only for the case of `EventLoggingListener.onEnvironmentUpdate` we are redacting event file itself - in all other cases of application of redaction regex, we do not modify the source (event file, spark map, etc), but rather change when presenting to user.
I am not sure if this was done intentionally (allowing superuser to look at the unredact properties - and so `onEnvironmentUpdate` is a bug) or was an oversight (in which case all properties should be redacted before event logging).
Thoughts ? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-733832829
@tgravescs The question I had was regarding when redaction is applied - while logging the event or when surfacing in UI/cli/etc.
Only for the case of `EventLoggingListener.onEnvironmentUpdate` we are redacting event file itself - in all other cases of application of redaction regex, we do not modify the source (event file, spark map, etc), but rather change when presenting to user.
I am not sure if this was done intentionally (allowing superuser to look at the unredact properties - and so `onEnvironmentUpdate` is a bug) or was an oversight (in which case all properties should be redacted before logging).
Thoughts ? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731601681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731401580
**[Test build #131441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131441/testReport)** for PR 30446 at commit [`33b6e24`](https://github.com/apache/spark/commit/33b6e24236aca95f9f5201c41f6af9160af039d1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731264186
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731469361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731764583
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36103/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731575518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731592160
**[Test build #131473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131473/testReport)** for PR 30446 at commit [`1a4e5c2`](https://github.com/apache/spark/commit/1a4e5c28e63985bf3c1742d6bf1d24bf075d1ca6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-736607828
sorry for my delay, behind on reviews.
I think we should redact from both ui/rest or from event logging as people may not realize event logging has the password and history server could allow viewing from people who shouldn't see those. If people want it differently I would say we add a config to allow it but have it off by default - but I would wait until someone requests this.
I think it was an oversight that these events weren't redacted. so if you see other cases we aren't we should fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
akiyamaneko commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731697893
@mridulm done this, please help to review again, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737303326
thanks @akiyamaneko @mridulm merged to master and branch-3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737297716
I will merge this shortly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm edited a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-733832829
@tgravescs The question I had was regarding when redaction is applied - while logging the event or when surfacing in UI/cli/etc.
Only for the case of `EventLoggingListener.onEnvironmentUpdate` we are redacting event file itself - in all other cases of application of redaction regex, we do not modify the event file, but rather change when presenting to user.
I am not sure if this was done intentionally (allowing superuser to look at the unredact properties - and so `onEnvironmentUpdate` is a bug) or was an oversight (in which case all properties should be redacted before logging).
Thoughts ? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731714720
**[Test build #131497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131497/testReport)** for PR 30446 at commit [`c231252`](https://github.com/apache/spark/commit/c23125276bf01f2e2d889f30da62ceb831a71baf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731721233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731583822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731774478
**[Test build #131499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131499/testReport)** for PR 30446 at commit [`effbead`](https://github.com/apache/spark/commit/effbead0db66c12dd7175b44e3023a706a6fec73).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731718598
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731583381
**[Test build #131469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131469/testReport)** for PR 30446 at commit [`84a1a28`](https://github.com/apache/spark/commit/84a1a2825149b7ea3be9acd8ed1371faeffbb61d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731694731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731600035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-736730605
Thanks for clarifying Tom ! Sounds good to me.
I am fine with this patch given @tgravescs's comments above.
We can have follow up work to redact from other events as well - at event logging time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737443694
https://github.com/apache/spark/pull/30576 is revert
@akiyamaneko could you port this to branch-3.0 and put up a PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731589358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731592408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731582642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732501522
**[Test build #131591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131591/testReport)** for PR 30446 at commit [`effbead`](https://github.com/apache/spark/commit/effbead0db66c12dd7175b44e3023a706a6fec73).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731754336
**[Test build #131499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131499/testReport)** for PR 30446 at commit [`effbead`](https://github.com/apache/spark/commit/effbead0db66c12dd7175b44e3023a706a6fec73).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731469361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731679482
**[Test build #131488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131488/testReport)** for PR 30446 at commit [`805d704`](https://github.com/apache/spark/commit/805d7046ceeef0c1a8a6244c8b59bf2ae68119a8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731433855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731401080
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731260640
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731575969
**[Test build #131467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131467/testReport)** for PR 30446 at commit [`fdb305c`](https://github.com/apache/spark/commit/fdb305c569b5170c4472d2e736ac8d7310c0b87d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731607635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731433855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
akiyamaneko commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737186228
@mridulm Does it need someone else to continue reviewing, or can someone help me merge the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731582640
**[Test build #131468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131468/testReport)** for PR 30446 at commit [`26440c3`](https://github.com/apache/spark/commit/26440c3369d9eebe7ff9734ef8e6f201964c69d5).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731592408
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a change in pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm commented on a change in pull request #30446:
URL: https://github.com/apache/spark/pull/30446#discussion_r527964297
##########
File path: core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
##########
@@ -97,6 +97,17 @@ class EventLoggingListenerSuite extends SparkFunSuite with LocalSparkContext wit
assert(redactedProps(key) == "*********(redacted)")
}
+ test("Spark-33504 password redaction in properties") {
+ val key = "spark.executorEnv.HADOOP_CREDSTORE_PASSWORD"
+ val secretPassword = "secret_password"
+ val conf = getLoggingConf(testDirPath, None).set(key, secretPassword)
+ val properties = new Properties()
+ properties.setProperty(key, secretPassword)
+ val eventLogger = new EventLoggingListener("test", None, testDirPath.toUri(), conf)
+ val redactedProperties = eventLogger.redactProperties(properties)
Review comment:
Test whether `SparkListenerJobStart` is updated as required ? `redactProperties` can be made private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731728526
**[Test build #131497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131497/testReport)** for PR 30446 at commit [`c231252`](https://github.com/apache/spark/commit/c23125276bf01f2e2d889f30da62ceb831a71baf).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731721229
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731754336
**[Test build #131499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131499/testReport)** for PR 30446 at commit [`effbead`](https://github.com/apache/spark/commit/effbead0db66c12dd7175b44e3023a706a6fec73).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731588711
**[Test build #131471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131471/testReport)** for PR 30446 at commit [`a73f527`](https://github.com/apache/spark/commit/a73f5278296ca58654402fb1b5f1baf95b26a492).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731582832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737423465
Could you take a look, please? I guess we need to recover the branch-3.0 first by reverting it and make a PR to `branch-3.0` to pass all CIs. But, it's up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-733832829
@tgravescs The question I had was regarding when redaction is applied - while logging the event or when surfacing in UI.
Only for the case of `EventLoggingListener.onEnvironmentUpdate` we are redacting event file itself - in all other cases of application of redaction regex, we do not modify the event file, but rather change when presenting to user.
I am not sure if this was done intentionally (allowing superuser to look at the unredact properties - and so `onEnvironmentUpdate` is a bug) or was an oversight (in which case all properties should be redacted before logging).
Thoughts ? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731774753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131499/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731596183
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36078/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731764574
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36103/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731593042
**[Test build #131474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131474/testReport)** for PR 30446 at commit [`cd4a184`](https://github.com/apache/spark/commit/cd4a184f067a0bd262049c05e842d0583ff635c1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731575253
**[Test build #131466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131466/testReport)** for PR 30446 at commit [`f03fdef`](https://github.com/apache/spark/commit/f03fdef1fc2cbabe950e1cca868dafb977a70013).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731584082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737441277
yeah lets revert first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731607515
**[Test build #131474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131474/testReport)** for PR 30446 at commit [`cd4a184`](https://github.com/apache/spark/commit/cd4a184f067a0bd262049c05e842d0583ff635c1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731264186
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731468662
**[Test build #131441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131441/testReport)** for PR 30446 at commit [`33b6e24`](https://github.com/apache/spark/commit/33b6e24236aca95f9f5201c41f6af9160af039d1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731764578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731592160
**[Test build #131473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131473/testReport)** for PR 30446 at commit [`1a4e5c2`](https://github.com/apache/spark/commit/1a4e5c28e63985bf3c1742d6bf1d24bf075d1ca6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731574965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731607639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131474/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
akiyamaneko commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-736955510
@mridulm @tgravescs thanks for your review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
akiyamaneko commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-769559581
@tgravescs sorry for delay, Is there anything I can do？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731699655
**[Test build #131488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131488/testReport)** for PR 30446 at commit [`805d704`](https://github.com/apache/spark/commit/805d7046ceeef0c1a8a6244c8b59bf2ae68119a8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731582375
**[Test build #131468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131468/testReport)** for PR 30446 at commit [`26440c3`](https://github.com/apache/spark/commit/26440c3369d9eebe7ff9734ef8e6f201964c69d5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731607635
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731593042
**[Test build #131474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131474/testReport)** for PR 30446 at commit [`cd4a184`](https://github.com/apache/spark/commit/cd4a184f067a0bd262049c05e842d0583ff635c1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731576400
**[Test build #131467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131467/testReport)** for PR 30446 at commit [`fdb305c`](https://github.com/apache/spark/commit/fdb305c569b5170c4472d2e736ac8d7310c0b87d).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732653727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #30446:
URL: https://github.com/apache/spark/pull/30446
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731592399
**[Test build #131473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131473/testReport)** for PR 30446 at commit [`1a4e5c2`](https://github.com/apache/spark/commit/1a4e5c28e63985bf3c1742d6bf1d24bf075d1ca6).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731694726
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36092/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-740677878
@akiyamaneko do you have time to back port?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
akiyamaneko commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732015828
@mridulm thanks for your great advice, Please review it again when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731588711
**[Test build #131471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131471/testReport)** for PR 30446 at commit [`a73f527`](https://github.com/apache/spark/commit/a73f5278296ca58654402fb1b5f1baf95b26a492).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731728690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731584083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131469/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737421893
Hi, @tgravescs .
There is a compilation error in `branch-3.0`.
```
[error] /home/runner/work/spark/spark/core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala:118: not found: value resourceProfileId
[error] Error occurred in an application involving default arguments.
[error] resourceProfileId = ResourceProfile.DEFAULT_RESOURCE_PROFILE_ID)
[error] ^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731401580
**[Test build #131441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131441/testReport)** for PR 30446 at commit [`33b6e24`](https://github.com/apache/spark/commit/33b6e24236aca95f9f5201c41f6af9160af039d1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732643164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731589139
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731600030
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36078/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731774750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731699843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731584078
**[Test build #131469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131469/testReport)** for PR 30446 at commit [`84a1a28`](https://github.com/apache/spark/commit/84a1a2825149b7ea3be9acd8ed1371faeffbb61d).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731694731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731714720
**[Test build #131497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131497/testReport)** for PR 30446 at commit [`c231252`](https://github.com/apache/spark/commit/c23125276bf01f2e2d889f30da62ceb831a71baf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731575254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731582642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731600035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731728691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131497/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732240844
So both of the configs in the jira look like they are user generated configs. It sounds like you updated the spark.redaction.regex config but that didn't work for these events. It seems like we just missed these, so thanks for catching this.
I think the current approach makes sense and matches our previous implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731679482
**[Test build #131488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131488/testReport)** for PR 30446 at commit [`805d704`](https://github.com/apache/spark/commit/805d7046ceeef0c1a8a6244c8b59bf2ae68119a8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731589349
**[Test build #131471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131471/testReport)** for PR 30446 at commit [`a73f527`](https://github.com/apache/spark/commit/a73f5278296ca58654402fb1b5f1baf95b26a492).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-769843416
I don't think anyone back ported it yet so if you have time it would be great to put up a version again branch-3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731764578
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732501522
**[Test build #131591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131591/testReport)** for PR 30446 at commit [`effbead`](https://github.com/apache/spark/commit/effbead0db66c12dd7175b44e3023a706a6fec73).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731576489
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731576403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731589141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731592416
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131473/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko edited a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
akiyamaneko edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737186228
@mridulm Does it need someone else to continue reviewing, or can someone help me merge the code? thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731433838
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731400801
redaction support looks kind of weird.
For `ApplicationEnvironmentInfo`, the event file contains unredacted event with the api redacting on demand.
On other hand, `SparkListenerEnvironmentUpdate` is redacted before getting logged into event file.
The current pr takes the approach of `SparkListenerEnvironmentUpdate` - and logs redacted events.
Personally I am inclined to have source of truth in the event file, and expose redacted view.
But then, all of these was last changed 4 years or so back (#15971).
Any thoughts @vanzin, @tgravescs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a change in pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
mridulm commented on a change in pull request #30446:
URL: https://github.com/apache/spark/pull/30446#discussion_r528284702
##########
File path: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
##########
@@ -103,7 +105,7 @@ private[spark] class EventLoggingListener(
// Events that do not trigger a flush
override def onStageSubmitted(event: SparkListenerStageSubmitted): Unit = {
- logEvent(event)
+ logEvent(SparkListenerStageSubmitted(event.stageInfo, redactProperties(event.properties)))
Review comment:
Use copy instead - here and elsewhere, to be forward compatible.
For example: `event.copy(properties = redactProperties(event.properties))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731589360
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131471/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731759915
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36103/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731699843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731260640
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731589139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731574965
**[Test build #131466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131466/testReport)** for PR 30446 at commit [`f03fdef`](https://github.com/apache/spark/commit/f03fdef1fc2cbabe950e1cca868dafb977a70013).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732644513
**[Test build #131591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131591/testReport)** for PR 30446 at commit [`effbead`](https://github.com/apache/spark/commit/effbead0db66c12dd7175b44e3023a706a6fec73).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731692871
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36092/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731576491
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36073/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-732643164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731420899
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731601681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30446: [SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-737423465
Could you take a look, please? I guess we need to recover the branch-3.0 first by reverting it and make a PR to `branch-3.0` to pass all CIs. But, it's up to you. Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30446: [spark-33504] The application log in the Spark history server contains sensitive attributes should be redated
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731575254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org