[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin
URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-378739069
 
 
   I agree on the [un] manageability of this file. The challenge is that the different visualizations both from a controls and API standpoint have a lot in common. A lot of code is shared in odd intricate ways. It's a though puzzle.
   
   A balanced way to evolve this would be to refactor out portion of the code into smaller functions an unit test those. 
   
   We've been talking about moving to `data-ui` / vx for a while, and maybe that's the end game and justify not spending too many cycles on `nvd3`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services