[GitHub] [ignite-3] rpuch commented on a diff in pull request #1534: IGNITE-18563 Reduce the list of duplicated jar dependencies

[GitBox <gi...@apache.org>]

rpuch commented on code in PR #1534:
URL: https://github.com/apache/ignite-3/pull/1534#discussion_r1072114151


##########
modules/sql-engine/build.gradle:
##########
@@ -45,7 +45,11 @@ dependencies {
     implementation libs.jackson.core
     implementation libs.jackson.databind
     implementation libs.jackson.annotations
-    implementation libs.jsonpath.core
+    implementation(libs.jsonpath.core) {
+        //IDEA test runner don't apply Gradle dependency resolve strategy, this is just not implemented

Review Comment:
   ```suggestion
           //IDEA test runner doesn't apply Gradle dependency resolve strategy, this is just not implemented
   ```



##########
modules/runner/build.gradle:
##########
@@ -83,7 +83,11 @@ dependencies {
     testImplementation libs.hamcrest.path
     testImplementation libs.mockito.core
     testImplementation libs.mockito.junit
-    testImplementation libs.jsonpath.assert
+    testImplementation(libs.jsonpath.assert) {
+        //IDEA test runner don't apply Gradle dependency resolve strategy, this is just not implemented

Review Comment:
   ```suggestion
           //IDEA test runner doesn't apply Gradle dependency resolve strategy, this is just not implemented
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org