You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/03/11 07:57:28 UTC
[PR] refactor(core/raw): Migrate `oio::Read` to async in trait [opendal]
Xuanwo opened a new pull request, #4336:
URL: https://github.com/apache/opendal/pull/4336
`oio::Read` used to by poll_based trait that developers need to implement the state machine. However, it's hard to maintain and doesn't have performance we want: since internal operations still need to use `Box::pin` inside `state`.
This will will migrate `oio::Read` to async in trait. And finally, other traits like `oio::Write` and `oio::List` will also be refactored.
This change doesn't affect our public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core/raw): Migrate `oio::Read` to async in trait [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #4336:
URL: https://github.com/apache/opendal/pull/4336#issuecomment-1987851019
I'm working in address CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core/raw): Migrate `oio::Read` to async in trait [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #4336:
URL: https://github.com/apache/opendal/pull/4336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core/raw): Migrate `oio::Read` to async in trait [opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #4336:
URL: https://github.com/apache/opendal/pull/4336#issuecomment-1990610793
Amazing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core/raw): Migrate `oio::Read` to async in trait [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #4336:
URL: https://github.com/apache/opendal/pull/4336#issuecomment-1990233179
I will add upgrade entries only the refactor is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org