You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mk...@apache.org on 2016/04/29 01:31:17 UTC
git commit: [flex-sdk] [refs/heads/develop] - FLEX-35082: Changed the
way regex was being used to compare the given pattern for dataProvider
objects in the findRowIndex / findRowIndices methods.
Repository: flex-sdk
Updated Branches:
refs/heads/develop ce0ec309d -> f2c02cbf0
FLEX-35082: Changed the way regex was being used to compare the given pattern for dataProvider objects in the findRowIndex / findRowIndices methods.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f2c02cbf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f2c02cbf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f2c02cbf
Branch: refs/heads/develop
Commit: f2c02cbf0c8a3c8e228fc2596933a411b2cbb781
Parents: ce0ec30
Author: Mark Kessler <Ke...@gmail.com>
Authored: Thu Apr 28 19:30:05 2016 -0400
Committer: Mark Kessler <Ke...@gmail.com>
Committed: Thu Apr 28 19:30:05 2016 -0400
----------------------------------------------------------------------
frameworks/projects/spark/src/spark/components/Grid.as | 4 ++--
.../spark/src/spark/components/supportClasses/ListBase.as | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f2c02cbf/frameworks/projects/spark/src/spark/components/Grid.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/Grid.as b/frameworks/projects/spark/src/spark/components/Grid.as
index 23a6d5f..5f9f0cd 100644
--- a/frameworks/projects/spark/src/spark/components/Grid.as
+++ b/frameworks/projects/spark/src/spark/components/Grid.as
@@ -4805,7 +4805,7 @@ public class Grid extends Group implements IDataGridElement, IDataProviderEnhanc
{
currentObject = dataProvider.getItemAt(loopingIndex);
- if (currentObject.hasOwnProperty(field) == true && currentObject[field].search(pattern) != -1)
+ if (currentObject.hasOwnProperty(field) == true && pattern.test(currentObject[field]) == true)
{
return loopingIndex;
}
@@ -4862,7 +4862,7 @@ public class Grid extends Group implements IDataGridElement, IDataProviderEnhanc
//Loop through regex patterns from the values array.
for (loopingValuesIndex = 0; loopingValuesIndex < valuesTotal; loopingValuesIndex++)
{
- if (currentObject[field].search(regexList[loopingValuesIndex]) != -1)
+ if (regexList[loopingValuesIndex].test(currentObject[field]) == true)
{
matchedIndices.push(loopingDataProviderIndex);
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f2c02cbf/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
index c72d4d5..e700d0d 100644
--- a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
+++ b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
@@ -1311,7 +1311,7 @@ public class ListBase extends SkinnableDataContainer implements IDataProviderEnh
{
currentObject = dataProvider.getItemAt(loopingIndex);
- if (currentObject.hasOwnProperty(field) == true && currentObject[field].search(pattern) != -1)
+ if (currentObject.hasOwnProperty(field) == true && pattern.test(currentObject[field]) == true)
{
return loopingIndex;
}
@@ -1368,7 +1368,7 @@ public class ListBase extends SkinnableDataContainer implements IDataProviderEnh
//Loop through regex patterns from the values array.
for (loopingValuesIndex = 0; loopingValuesIndex < valuesTotal; loopingValuesIndex++)
{
- if (currentObject[field].search(regexList[loopingValuesIndex]) != -1)
+ if (regexList[loopingValuesIndex].test(currentObject[field]) == true)
{
matchedIndices.push(loopingDataProviderIndex);