You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Martin Sebor <se...@roguewave.com> on 2007/06/04 20:36:05 UTC
Re: [PING] Re: svn commit: r541672 - /incubator/stdcxx/trunk/include/rw/_config-msvc.h
Farid Zaripov wrote:
>> Farid, do you agree that this is the way to go? If you do, do
>> you plan to move the Intel C++ specific code to the
>> _config-icc.h header? (Just making sure this doesn't slip
>> through the cracks.)
>
> I need to inspect what the macros from _config_msvc.h are Intel C++
> compiler specific (except disabled warnings).
>
> What I see, is that we could remove all section between
> #if _MSC_VER <= 1200 // MSVC <= 6.0
> and
> #endif // MSVC <= 6.0
> because of the all macros are defined in config.h at the configure
> step.
I think the reason why they are defined in _config_msvc.h is
because the autoconfigured ones are (or were at some point)
incorrectly detected. That certainly may have changed so we
need to check to make sure they are now detected correctly
before we take out the overriding definitions.
Martin
RE: [PING] Re: svn commit: r541672 - /incubator/stdcxx/trunk/include/rw/_config-msvc.h
Posted by Farid Zaripov <Fa...@epam.com>.
> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]
> Sent: Tuesday, June 05, 2007 7:02 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: [PING] Re: svn commit: r541672 -
> /incubator/stdcxx/trunk/include/rw/_config-msvc.h
>
> > I was not carefully read the comments. Since that section
> is related
> > to the MSVC 6.0 and earlier, I can't check whether that macros
> > detected correctly or not.
>
> Okay, I assume that doesn't change our decision to add the
> new config header (_config-msvcrt.h), correct?
Correct.
Farid.
Re: [PING] Re: svn commit: r541672 - /incubator/stdcxx/trunk/include/rw/_config-msvc.h
Posted by Martin Sebor <se...@roguewave.com>.
Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com]
>> Sent: Monday, June 04, 2007 9:36 PM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: [PING] Re: svn commit: r541672 -
>> /incubator/stdcxx/trunk/include/rw/_config-msvc.h
>>
>>> What I see, is that we could remove all section between
>>> #if _MSC_VER <= 1200 // MSVC <= 6.0
>>> and
>>> #endif // MSVC <= 6.0
>>> because of the all macros are defined in config.h at the
>> configure
>>> step.
>> I think the reason why they are defined in _config_msvc.h is
>> because the autoconfigured ones are (or were at some point)
>> incorrectly detected. That certainly may have changed so we
>> need to check to make sure they are now detected correctly
>> before we take out the overriding definitions.
>
> I was not carefully read the comments. Since that section is related
> to
> the MSVC 6.0 and earlier, I can't check whether that macros detected
> correctly or not.
Okay, I assume that doesn't change our decision to add the new
config header (_config-msvcrt.h), correct? You can just move
all these conditionally #defined macros there for now. At some
point in the future we'll clean up all the MSVC 6.0 cruft since
I don't think we'll ever go back and try to support it.
Martin
RE: [PING] Re: svn commit: r541672 - /incubator/stdcxx/trunk/include/rw/_config-msvc.h
Posted by Farid Zaripov <Fa...@epam.com>.
> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]
> Sent: Monday, June 04, 2007 9:36 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: [PING] Re: svn commit: r541672 -
> /incubator/stdcxx/trunk/include/rw/_config-msvc.h
>
> > What I see, is that we could remove all section between
> > #if _MSC_VER <= 1200 // MSVC <= 6.0
> > and
> > #endif // MSVC <= 6.0
> > because of the all macros are defined in config.h at the
> configure
> > step.
>
> I think the reason why they are defined in _config_msvc.h is
> because the autoconfigured ones are (or were at some point)
> incorrectly detected. That certainly may have changed so we
> need to check to make sure they are now detected correctly
> before we take out the overriding definitions.
I was not carefully read the comments. Since that section is related
to
the MSVC 6.0 and earlier, I can't check whether that macros detected
correctly or not.
Farid.