You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/20 23:41:52 UTC
Review Request 46456: Clarified and improved documentation for
maintenance primitives.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46456/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
Clarified and improved documentation for maintenance primitives.
Diffs
-----
docs/endpoints/master/maintenance/schedule.md 577e43c5faa961acb75f66e0db6729d7db9d88bf
docs/maintenance.md b86ccf62702aa776a7ed5455331307e9657138da
src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
Diff: https://reviews.apache.org/r/46456/diff/
Testing
-------
Previewed in site-docker.
Thanks,
Neil Conway
Re: Review Request 46456: Clarified and improved documentation for
maintenance primitives.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46456/#review129839
-----------------------------------------------------------
Fix it, then Ship it!
Reads fine to me.
docs/maintenance.md (line 303)
<https://reviews.apache.org/r/46456/#comment193372>
Nit: The rest of the document capitalizes the first letter of each mode.
- Joseph Wu
On April 20, 2016, 2:41 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46456/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 2:41 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clarified and improved documentation for maintenance primitives.
>
>
> Diffs
> -----
>
> docs/endpoints/master/maintenance/schedule.md 577e43c5faa961acb75f66e0db6729d7db9d88bf
> docs/maintenance.md b86ccf62702aa776a7ed5455331307e9657138da
> src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
>
> Diff: https://reviews.apache.org/r/46456/diff/
>
>
> Testing
> -------
>
> Previewed in site-docker.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46456: Clarified and improved documentation for
maintenance primitives.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46456/#review129840
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46456]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 20, 2016, 9:41 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46456/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 9:41 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clarified and improved documentation for maintenance primitives.
>
>
> Diffs
> -----
>
> docs/endpoints/master/maintenance/schedule.md 577e43c5faa961acb75f66e0db6729d7db9d88bf
> docs/maintenance.md b86ccf62702aa776a7ed5455331307e9657138da
> src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
>
> Diff: https://reviews.apache.org/r/46456/diff/
>
>
> Testing
> -------
>
> Previewed in site-docker.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46456: Clarified and improved documentation for
maintenance primitives.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46456/#review129850
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46456]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 21, 2016, 12:39 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46456/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 12:39 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clarified and improved documentation for maintenance primitives.
>
>
> Diffs
> -----
>
> docs/endpoints/master/maintenance/schedule.md 577e43c5faa961acb75f66e0db6729d7db9d88bf
> docs/maintenance.md b86ccf62702aa776a7ed5455331307e9657138da
> src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
>
> Diff: https://reviews.apache.org/r/46456/diff/
>
>
> Testing
> -------
>
> Previewed in site-docker.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46456: Clarified and improved documentation for
maintenance primitives.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46456/
-----------------------------------------------------------
(Updated April 21, 2016, 12:39 a.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Address review comment.
Repository: mesos
Description
-------
Clarified and improved documentation for maintenance primitives.
Diffs (updated)
-----
docs/endpoints/master/maintenance/schedule.md 577e43c5faa961acb75f66e0db6729d7db9d88bf
docs/maintenance.md b86ccf62702aa776a7ed5455331307e9657138da
src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
Diff: https://reviews.apache.org/r/46456/diff/
Testing
-------
Previewed in site-docker.
Thanks,
Neil Conway