You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Karen Miller <km...@pivotal.io> on 2016/12/13 22:49:53 UTC
Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/
-----------------------------------------------------------
Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
Repository: geode
Description
-------
- First operation to a transactional system which has colocated
data and replicated/distributed regions must be to a
partitioned region (with colocated data), to set the transaction
host. Note that this was already documented, but not in a
prominent place. Now the basics of this info is repeated in
a less-buried location.
- Fixed poorly-working links within the subnav and fixed a
couple of markdown errors. The errors were improperly
specified anchor tags.
Diffs
-----
geode-book/master_middleman/source/subnavs/geode-subnav.erb 16aa1e78cb4ca64489c3c2c5d9fd4240684b0858
geode-docs/developing/transactions/cache_transactions_by_region_type.html.md.erb fa3318a38356963262ea342d39fa98940812aa7e
geode-docs/developing/transactions/chapter_overview.html.md.erb b5e84a415451074e1ec803e0add20c7fe3272408
geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
Diff: https://reviews.apache.org/r/54723/diff/
Testing
-------
gradle rat check passes
Geode book builds with no broken links
Thanks,
Karen Miller
Re: Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
Posted by Karen Miller <km...@pivotal.io>.
> On Dec. 13, 2016, 11:11 p.m., Eric Shu wrote:
> > geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb, line 44
> > <https://reviews.apache.org/r/54723/diff/1/?file=1583275#file1583275line44>
> >
> > Product may throw TransactionDataRebalancedException instead of TransactionDataNotColocatedException. Do we need to specify exact exception?
Wording changed to say that there will be an exception, but not which exception.
I'll rebase the second commit before merging to develop.
- Karen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/#review159073
-----------------------------------------------------------
On Dec. 14, 2016, 4:33 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54723/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:33 p.m.)
>
>
> Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - First operation to a transactional system which has colocated
> data and replicated/distributed regions must be to a
> partitioned region (with colocated data), to set the transaction
> host. Note that this was already documented, but not in a
> prominent place. Now the basics of this info is repeated in
> a less-buried location.
> - Fixed poorly-working links within the subnav and fixed a
> couple of markdown errors. The errors were improperly
> specified anchor tags.
>
>
> Diffs
> -----
>
> geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
>
> Diff: https://reviews.apache.org/r/54723/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Geode book builds with no broken links
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/#review159073
-----------------------------------------------------------
geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb (line 44)
<https://reviews.apache.org/r/54723/#comment230016>
Product may throw TransactionDataRebalancedException instead of TransactionDataNotColocatedException. Do we need to specify exact exception?
- Eric Shu
On Dec. 13, 2016, 10:49 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54723/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 10:49 p.m.)
>
>
> Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - First operation to a transactional system which has colocated
> data and replicated/distributed regions must be to a
> partitioned region (with colocated data), to set the transaction
> host. Note that this was already documented, but not in a
> prominent place. Now the basics of this info is repeated in
> a less-buried location.
> - Fixed poorly-working links within the subnav and fixed a
> couple of markdown errors. The errors were improperly
> specified anchor tags.
>
>
> Diffs
> -----
>
> geode-book/master_middleman/source/subnavs/geode-subnav.erb 16aa1e78cb4ca64489c3c2c5d9fd4240684b0858
> geode-docs/developing/transactions/cache_transactions_by_region_type.html.md.erb fa3318a38356963262ea342d39fa98940812aa7e
> geode-docs/developing/transactions/chapter_overview.html.md.erb b5e84a415451074e1ec803e0add20c7fe3272408
> geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
>
> Diff: https://reviews.apache.org/r/54723/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Geode book builds with no broken links
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/#review159169
-----------------------------------------------------------
Ship it!
Ship It!
- Joey McAllister
On Dec. 14, 2016, 4:33 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54723/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:33 p.m.)
>
>
> Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - First operation to a transactional system which has colocated
> data and replicated/distributed regions must be to a
> partitioned region (with colocated data), to set the transaction
> host. Note that this was already documented, but not in a
> prominent place. Now the basics of this info is repeated in
> a less-buried location.
> - Fixed poorly-working links within the subnav and fixed a
> couple of markdown errors. The errors were improperly
> specified anchor tags.
>
>
> Diffs
> -----
>
> geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
>
> Diff: https://reviews.apache.org/r/54723/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Geode book builds with no broken links
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/#review159186
-----------------------------------------------------------
Ship it!
Ship It!
- Dave Barnes
On Dec. 14, 2016, 4:33 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54723/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:33 p.m.)
>
>
> Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - First operation to a transactional system which has colocated
> data and replicated/distributed regions must be to a
> partitioned region (with colocated data), to set the transaction
> host. Note that this was already documented, but not in a
> prominent place. Now the basics of this info is repeated in
> a less-buried location.
> - Fixed poorly-working links within the subnav and fixed a
> couple of markdown errors. The errors were improperly
> specified anchor tags.
>
>
> Diffs
> -----
>
> geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
>
> Diff: https://reviews.apache.org/r/54723/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Geode book builds with no broken links
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/#review159168
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Dec. 14, 2016, 4:33 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54723/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:33 p.m.)
>
>
> Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - First operation to a transactional system which has colocated
> data and replicated/distributed regions must be to a
> partitioned region (with colocated data), to set the transaction
> host. Note that this was already documented, but not in a
> prominent place. Now the basics of this info is repeated in
> a less-buried location.
> - Fixed poorly-working links within the subnav and fixed a
> couple of markdown errors. The errors were improperly
> specified anchor tags.
>
>
> Diffs
> -----
>
> geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
>
> Diff: https://reviews.apache.org/r/54723/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Geode book builds with no broken links
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54723: GEODE-2208 Document transactions limitation
with mixed region types.
Posted by Karen Miller <km...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54723/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 4:33 p.m.)
Review request for geode, Dave Barnes, Eric Shu, and Joey McAllister.
Repository: geode
Description
-------
- First operation to a transactional system which has colocated
data and replicated/distributed regions must be to a
partitioned region (with colocated data), to set the transaction
host. Note that this was already documented, but not in a
prominent place. Now the basics of this info is repeated in
a less-buried location.
- Fixed poorly-working links within the subnav and fixed a
couple of markdown errors. The errors were improperly
specified anchor tags.
Diffs (updated)
-----
geode-docs/developing/transactions/data_location_cache_transactions.html.md.erb d96de82fa7d5f4074c88863c1732363530c12d39
Diff: https://reviews.apache.org/r/54723/diff/
Testing
-------
gradle rat check passes
Geode book builds with no broken links
Thanks,
Karen Miller