[GitHub] [druid] kfaraz commented on a diff in pull request #13114: Fix over-replication caused by balancing when inventory is not updated yet

[GitBox <gi...@apache.org>]

kfaraz commented on code in PR #13114:
URL: https://github.com/apache/druid/pull/13114#discussion_r976032416


##########
server/src/test/java/org/apache/druid/server/coordinator/simulate/SegmentLoadingNegativeTest.java:
##########
@@ -217,44 +217,4 @@ public void testLoadOfFullyReplicatedSegmentIsNotCancelled()
     );
   }
 
-  /**
-   * Correct behaviour: Balancing should never cause over-replication, even when
-   * the inventory view is not updated.
-   * <p>
-   * Fix Apache #12881 to fix this test.
-   */
-  @Test
-  public void testBalancingWithStaleInventoryCausesOverReplication()

Review Comment:
   Moved this test to `SegmentLoadingTest.testBalancingWithoutSyncedInventory()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org