[jira] [Comment Edited] (CALCITE-2905) Migrate build system to Gradle

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973319#comment-16973319 ] 

Vladimir Sitnikov edited comment on CALCITE-2905 at 11/13/19 12:57 PM:
-----------------------------------------------------------------------

Update: [the build is ok|https://github.com/apache/calcite/pull/1571] for macOS (GitHub Actions) and Linux (Travis): 

The tests are executed, and the jars are built.

I would recommend trying the new build to see if there are edge cases.

 

Note: currently fmpp/javacc tasks are not executed automatically when the project is imported to IDEs, so one needs to call `./gradlew javaCCMain javaCCTest` in order to generate the parser files. That, however, will be automatic soon.

 

PS There's weird [javadoc: error - cannot read Input length = 1|https://github.com/apache/calcite/pull/1571/checks?check_run_id=300915758#step:4:1295] error in GitHub Actions / Windows / Java 13 environment.


was (Author: vladimirsitnikov):
Update: the build is ok for macOS (GitHub Actions) and Linux (Travis).

The tests are executed, and the jars are built.

I would recommend trying the new build to see if there are edge cases.

 

Note: currently fmpp/javacc tasks are not executed automatically when the project is imported to IDEs, so one needs to call `./gradlew javaCCMain javaCCTest` in order to generate the parser files. That, however, will be automatic soon.

 

PS There's weird "javadoc: error - cannot read Input length = 1" error in GitHub Actions / Windows / Java 13 environment.

> Migrate build system to Gradle
> ------------------------------
>
>                 Key: CALCITE-2905
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2905
>             Project: Calcite
>          Issue Type: Improvement
>    Affects Versions: 1.18.0
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current build system has quirks, and it has well-known limitations.
>  
> For instance:
> 1) If you change code in "core" and or "linq4j" modules and you want to check "cassandra", you need to "mvn install" those modules first otherwise "cassandra" would use "core" from the local Maven repository
> 2) If you want to see how Calcite plays together with Drill, it has to be multi-step as well. You can't just change some bits in Calcite and just build/test Drill
> 3) Maven builds seem to be single-threaded by default. For instance, checkstyle/forbiddenapis always goes before compile, and it does take time. I happen to disable checkstyle for local checks.
> 4) Maven plugins are hard to write. You can't just have a pair of classes to be used during the build.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)