[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9612: [BUG] fix information_schema.columns results not correctly on vec engine

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #9612:
URL: https://github.com/apache/incubator-doris/pull/9612#discussion_r874566823


##########
be/src/vec/exec/vschema_scan_node.cpp:
##########
@@ -69,12 +69,14 @@ Status VSchemaScanNode::get_next(RuntimeState* state, vectorized::Block* block,
     if (!_is_init) return Status::InternalError("used before initialize.");
     RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT));
     RETURN_IF_CANCELLED(state);
-    bool mem_reuse = block->mem_reuse();
-    DCHECK(block->rows() == 0);
     std::vector<vectorized::MutableColumnPtr> columns(_slot_num);
     bool schema_eos = false;
 
     do {
+        bool mem_reuse = block->mem_reuse();

Review Comment:
   Now there are no filter inside do-while loop in mysql and odbc scan node, we will never go to next loop with block->rows==0.
   
   For feature plan, I think we should better refractor mem_resue to reduce the risk of incorrectly using.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org