You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/03/30 06:57:57 UTC

[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #1798: chore(bindings/nodejs): init benchmark

suyanhanx commented on code in PR #1798:
URL: https://github.com/apache/incubator-opendal/pull/1798#discussion_r1152813603


##########
bindings/nodejs/package.json:
##########


Review Comment:
   > I guess we don't need to, let's keep it simple to get started.
   
   My point is, only install them when need to run benchmarks. These deps are not necessary during development.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org